Git Product home page Git Product logo

Comments (2)

maael avatar maael commented on June 2, 2024

Hi, thanks for the feedback and reporting this, I'll try to look at it today. It's likely just some minor HTML differences that I'll need to account for and make the data collection more resilient against.

from temtem-api.

maael avatar maael commented on June 2, 2024

I looked into this, and it was due to an issue when getting the data for techniques, basically there is a function that gets the rows in the info box (the thing at the top of wiki pages with info and an image in), and gets the data for a given row in it. However it was doing this by looking for text anywhere in the row, rather than by the title. So when trying to get the data for the row named Targets, because Targets is in Toxic Plume's synergy effect, it got that first.

I've changed it so it fetches it actually based on the title of the row, not the content. It also checks for completely matching text, not just that the expected title is included somewhere.

I've refreshed the technique data so this is fixed for Toxic Plume, and the changes I've made should mean this doesn't happen again.

Thanks for catching it!

from temtem-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.