Attoparsec parsers about chomp HOT 6 OPEN

I have a somewhat a need for choice. Since variadic functions aren't possible in rust (yet), I'm wondering what the performance implications are when passing a slice of parsers. OTOH, macros may be utilized to sugar nested or functions.

from chomp.

@dashed What kind of need? The reason I have not yet implemented choice is that it I am unsure if it should accept a list of function poiinters or a list of closures. The list-of-function-pointers is different in that it only has one level of indirection from the original slice compared to two of the closures. The first one does not need to box anything but for closures you need to since they are dynamically sized.

As for using or, there is already a sugar for this in the form of the <|> operator in the parse! macro. This is most likely the best solution if you have a static list of branches for the parser.

from chomp.

I recently discovered <|> operator which seems to make things a bit nicer.

from chomp.

@m4rw3r Do you know if there's a better way to do skip_many_till? Essentially many_till that doesn't return.

from chomp.

@dashed To properly make it it would require some additional methods on the internal trait for the bounded combinators. But there is an easy way by implementing a sink implementing FromIterator which will just discard all the data.

from chomp.

@m4rw3r Thanks for the suggestion! I'll try to investigate this approach.

from chomp.