Emojis are broken about neko HOT 7 CLOSED

Might have been broken by afbd1f6 or b88f175, because no recent major changes have been done. @mbattista.

EDIT: Can confirm, that rollback just before b88f175 did fix the issue.

from neko.

emoji-datasource has been upgraded to new major version, what can cause problems:

b88f175#diff-1846122c2c83a486a3693f7966aa522c34cf489f674185c4da0d9221683fd81fR27

from neko.

I will look at it

from neko.

I already figured out the solution. They changed row cont from 57 to 58.

It would be nice to have this as variable from the package, insted of just a constant.

from neko.

It looks like, now the names are not correct.

from neko.

It seems the downgrade was not necessary if I bump it again, the emojis still look good.

Also I think that fixing with downgrading should never close an issue, since the problem is still there!

from neko.

You are right, that just postpones it.

Upgrading emojilib to new major version has many beaking changes, listed here: https://www.npmjs.com/package/emojilib

Since emojis are generated statically, you need to run npm run build:emoji to regenerate them. With new version you get ton of erros, because it has been completly changed. That might need complete rewrite.

from neko.