Comments (5)
Hi @dbatten5 , thank you for taking the time to open the issue and volunteering to do a PR. I'm afraid it's a "feature", autoimport
parses the source code and divides it into four sections: header, imports, typing, and code. You can see it here. I thought it was interesting to add a new line between each section to improve readability.
That being said, I'm not against adding a config option to disable this behaviour. Sadly, autoimport
doesn't yet have that feature implemented, so there is no way to deviate from the standard opinionated workflow. This has been raised too in yamlfix
another fixer I maintain. If you were to make a PR I'd point in that direction.
Ideally for me, autoimport
could read it's configuration from a section in the pyproject.toml
project file, to avoid creating new fixer files in the repository, but if you have other ideas, I'm more than open to them.
from autoimport.
hi @lyz-code yeah i think reading from pyproject.toml
would be a good starting point. i'd be happy to try and implement that and once that's in place could tackle the blank line config option?
from autoimport.
Sounds really good to me :)
from autoimport.
just coming back to this now - i think this is mentioned in the docs as well but typically i just run black
after autoimport
which resolves any potential formatting issues. happy to close this issue as i don't really see it as an issue any more
from autoimport.
I'm fine with closing it too, if anyone still sees it as an issue, please
comment here and we'll reopen it.
from autoimport.
Related Issues (20)
- `typing.Literal` can cause false-positive import HOT 3
- Preserve line endings HOT 2
- Pre-generate module symbol list HOT 1
- Extra blank lines after imports are removed HOT 2
- Stdout of unmodified script should be returned even if autoimport fails to resolve libraries HOT 3
- crashes with `ValueError` when the import to remove appears twice HOT 2
- Flag to skip for `__init__.py` files HOT 3
- [Bug] handling top-level `if TYPE_CHECKING: ...` block HOT 3
- Maintenance mode. Help needed! HOT 1
- Add `--ignore-init-modules` to configurable options HOT 3
- Move away from the `xdg` package HOT 5
- Bug: Interaction between `TYPE_CHECKING` and star import HOT 1
- Bug: unused multiline import statement trigges re.error HOT 1
- Bug: Import of type "from module import (func1, func2)" can trigger ValueError HOT 1
- Mac arm64 issues HOT 1
- Option to disable "move-to-top" feature HOT 1
- Broken syntax with multiline, function-local imports HOT 3
- Allow fixing unicode files with non-ASCII characters on Windows HOT 1
- Deleted dependency detected HOT 1
- Pull Request maintenance only :(
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autoimport.