Make `IGNORED` URLs failures more visible in the summary about lychee HOT 5 OPEN

Ignored URLs should not fail the pipeline. We should look into that. My guess is that we improved link validation, but forgot to account for the ignored link errors in the exit code.

from lychee.

0.12.0 with the fix is out. Can you check again?

from lychee.

The failures on IGNORED URLs is now fixed in v0.12.0 (tested via lychee-action v1.7.0); appreciate the fix ❤️

@mre: I will leave this issue open for you to decide whether the underlying suggestion here — listing the ignored URLs in the summary, as a possible prompt for the user to investigate the logs — is worth including or not. It might help catch malformed URLs in some cases. If you don't think that's useful, it's fine to close the issue.

from lychee.

Yes, I'd be willing to add that.
Here's what needs to be done:

• Add another block to iterate over the ignored links here:

  lychee/lychee-bin/src/formatters/stats/markdown.rs

  Lines 103 to 105 in a7ddcac

  	write_stats_per_input(f, "Errors", &stats.fail_map, |response| {
  	markdown_response(response).map_err(|_e| fmt::Error)
  	})?;

• Update the tests in the file.
• Same for the other formatters here (where it makes sense).

I'd be happy to receive a pull request for that.

from lychee.

Just tested and this is fixed in master and will be fixed with the next release.

from lychee.