Git Product home page Git Product logo

Comments (3)

mre avatar mre commented on August 11, 2024

Nice idea! We could add a skip-retry option that defaults to 404. If anyone is interested in working on this, post a comment here. @pawroman and me are happy to help. 😊

from lychee.

mre avatar mre commented on August 11, 2024

So after looking at the code again, I'm not sure if there's anything left to do here.
At the moment we accept any HTTP status code and don't retry if we get a "valid" response.

if status.is_success() {
return status;
}

So no matter if we receive a 200 or a 404, we don't retry. Only if there was an invalid status code we check again.
Makes sense to me actually. What do you think?

from lychee.

mre avatar mre commented on August 11, 2024

I think this is done. Closing this to keep the issue tracker clean. @pawroman feel free to reopen. 😉

from lychee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.