publish container images to ghcr.io about lychee HOT 5 CLOSED

0.14.3 is out now. I retriggered the pipeline. Don't know why it wasn't triggered before, but it wasn't the tagging. That part works. So we just need to keep an eye out for the next release. Maybe I'm missing a trigger somewhere.

As you said, maintaining two registries would cause some overhead, so I'd prefer to avoid that. 😉

With that, I think we can close this.

from lychee.

Sorry, I don't understand what's the advantage of ghcr over Dockerhub. Why do we need both?

As of now, docker images are not tagged with new lychee version.
For example, we have 0.14.3 tag in GitHub releases but I don't have the image with that tag on DockerHub.

That's a bug. I think I'm missing the patch directive in the Docker workflow here:

Maybe that's all it takes to fix it.

I intend to use it in the following manner in a multistage pipeline.

FROM ghcr.io/lycheeverse/lychee:0.14.3 as lychee
COPY --from=lychee /usr/bin/lychee /usr/bin/lychee

This should already be possible (if the tag was available).

/tmp ❯❯❯ cat Dockerfile                                                                                                                                                                                       
FROM debian:latest
COPY --from=lycheeverse/lychee /usr/local/bin/lychee /usr/bin/lychee


/tmp ❯❯❯ docker build --tag foo .
[+] Building 0.6s (8/8) FINISHED  
...
                                                                                                                          
/tmp ❯❯❯ docker run --entrypoint /usr/bin/lychee foo
error: the following required arguments were not provided:
  <inputs>...

Usage: lychee <inputs>...

For more information, try '--help'.

Note that the path to lychee inside the Docker image is
/usr/local/bin/lychee (not /usr/bin/lychee).

from lychee.

I don't understand what's the advantage of ghcr over Dockerhub. Why do we need both?

We don't need both for sure, I just wanted to depend on ghcr.io for tagging. If the tagging issue is already solved via DockerHub registry then that will be great.

From a project perspective, using ghcr.io registry will allow everyone to run CI on forks otherwise, in current context, I've to change the name of the image in workflow file.
In case of ghcr.io we can use github.actor and more variables related to GitHub.
But I also don't want the project to maintain images in two registries so I'll tagging issue will solve the problem completely.

from lychee.

@mre @thomas-zahner Thank you for the new release.
I think images for v0.15.0 is missing in the registry.

On DockerHub, I can see that we have latest, master, latest-alpine, master-alpine tag but not the semver tag that one can track with ongoing releases.

I'll take a more deeper look into the pipeline during the weekend and see if I can fix it if it's not fixed already.

from lychee.

@kranurag7, sure, let's look into it. Could you create a new issue, though, as this one is closed? 🙂

from lychee.