[Bug] After clicking `copy to` on a photo, the photo will appear twice. But disappear after a refresh. about lychee-front HOT 1 CLOSED

I had a look at it and my conclusion is that the whole Copy to... functionality is pretty messed up...

The feature is implemented in the front end using the Photo::duplicate API. But that call does not allow one to specify the destination: the duplicate is always added to the current album. Also, the ID of the newly generated duplicate is not returned to the caller. So after duplicating a photo, the front end reloads the album (that's why the reporter of this issue sees a duplicate) and then moves the original to the destination album. Moving the original instead of the duplicate is wrong: it can affect the sorting order of the photos inside the current album. But, as I said, the ID of the duplicate is not known to the front end.

Also, Photo::duplicate in the server appears slightly broken as well: it fails to generate a new ID for the duplicate. I'm guessing Laravel (or the database?) generates it instead, but the one that gets generated does not reflect the current time.

My proposal would be to modify the server so that Photo::duplicate accepts an optional destination album ID argument. That would make things much more robust by removing all that half-broken code from the front end.

from lychee-front.