Comments (11)
Duplicate: LycheeOrg/Lychee#37
(I will be honest I am using arrow keys to switch pictures and i
to show the info so.. :S)
from lychee-front.
It's not only about the buttons in the issue, it is also about the image not being resized and centred but overlapped by the active sidebar. So please at least open that part again .. hehe.
from lychee-front.
GRBLLLL
from lychee-front.
it is also about the image not being resized and centred but overlapped by the active sidebar.
I'd say the two are linked.
from lychee-front.
"GRBLLLL" LOL... sorry :-P
I wouldn't say that they are linked. Compare behaviour of the settings sidebar moving the main content area to the right, and the "About"-Sidebar overlapping the content area. I think the behaviour of sidebars should be consistent. :-)
from lychee-front.
TBH, I don't mind the overlapping of the content area in the sense that it changes "less" the visual that completely resizing the picture.
from lychee-front.
Small display, big images, whatever, you wanna fast step through images with Information sidebar open and always the right part of an image is cutted. I don't think that is good for every user. Just my 2 cent.
from lychee-front.
I think there's an expectations issue here. I've always thought of the sidebar of a sort of overlay (so overlapping), but I'm inclined to lean towards it being a sidebar (so not overlapping). The former lends itself more to quickly looking at the info for a photo as you think "Oh, I wonder..." whereas the latter lends itself more to being open all the time (or toggled on for multiple photos).
I don't have any strong opinions either way, but I think it's a design decision to be made rather than a definite problem to be fixed.
from lychee-front.
I called it "issue" not problem or bug exactly because of that, but I strongly thing sidebar behaviour should be consistence. It makes more sense to have the info sidebar NOT overlapping as you still use "both" areas (main content & sidebar) but the settings sidebar.
from lychee-front.
Perhaps. Though I'm not sure how relevant this is as the two sidebars can't be displayed at the same time (Not that I'd be against being able to show the left bar at any time...). As it's temporary (it doesn't stay open and in the way) I also wouldn't be against flipping this so that the left sidebar overlapped the content too.
At this point I think I'll step back as I think I'm only adding confusion!
from lychee-front.
I just submitted a PR that should make it all consistent: no content overlap in any of the albums/album/photo views, irrespective of the layout used for the album view. Right now we have this inconsistent... mess that, IMHO, is more of an emergent behavior from a series of patches piled on top of each other than a result of conscious design decisions. In particular, justified layout was the only one where the sidebar would overlap photos in album view, but even that seemed accidental (e.g., try to resize the window in that situtation and see what happens).
from lychee-front.
Related Issues (20)
- suggestion: remove google fonts dependency HOT 2
- iOS Mobile Site - No scrolling of target list on move of picture HOT 1
- Mov files get imported with thumbnail but only sound is played HOT 2
- Css is too complex to permit anyone to create new theme HOT 6
- Wrong support of ' (single quote) in some places (French localisation)
- 'About' window stays open when viewing 'Settings' and other sections in sidebar HOT 1
- Problem with responsive design on iOS
- [Enhancement] Make login dialog more prominent, auto-show login dialog if necessary, hide empty smart folders for anonymous users HOT 12
- Refreshing (F5) an album or photo from within the search results fails with 422 HOT 4
- [Enhancement] SEO optimization 2/3 - Set `<meta name="robots" content="noindex">` for 404 responses
- [Enhancement] SEO optimization 3/3 - Don't use fragments for client-side navigation, but proper URLs HOT 6
- [Enhancement] SEO optimization 4/3 - Use `<a>`-tags in a semantical correct way
- Scroll position should only be restored when navigating from photos back to their album HOT 9
- [Regression] Photos in the unsorted album cannot be edited HOT 1
- On iPad Pro - the settings menu does not disappear HOT 6
- WebAuthn.js does not work on older Safari versions HOT 2
- Share button is shown on photo page even if `share_button_visible` is not set
- Album view: wrong line breaks when scrollbars are visible HOT 1
- Photo view: More menu shows when it shouldn't HOT 2
- Link for Logs is invalid HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lychee-front.