Git Product home page Git Product logo

Comments (6)

lvermeulen avatar lvermeulen commented on June 27, 2024

Sorry for the delay in replying. On which call in the library are you seeing this?

from bitbucket.net.

richardgavel avatar richardgavel commented on June 27, 2024

Sorry for the feedback delay. This is the call.

public async Task<CommentRef> CreatePullRequestCommentAsync(string projectKey, string repositorySlug, long pullRequestId,
. Even though the invocation supports providing only the comment itself, with the other parameters optional, those nulls will still be made part of the JSON that gets posted instead of non-existent properties.

from bitbucket.net.

richardgavel avatar richardgavel commented on June 27, 2024

This is the exact code I'm using in a replacement:

        public async Task CreatePullRequestCommentAsync(string projectKey, string repositorySlug, long pullRequestId, string text)
        {
            try
            {
                var requestUri = $"rest/api/1.0/projects/{projectKey}/repos/{repositorySlug}/pull-requests/{pullRequestId}/comments";
                var body = new
                {
                    text
                };

                var content = new StringContent(JsonConvert.SerializeObject(body), Encoding.Default, "application/json");
                var response = await _httpClient.PostAsync(requestUri, content);
                response.EnsureSuccessStatusCode();
            }
            catch (HttpRequestException ex)
            {
                _logger.LogError(ex, "Error creating pull request comment ({Message})", ex.Message);
                throw;
            }
        }

from bitbucket.net.

lvermeulen avatar lvermeulen commented on June 27, 2024

I'm on it.

from bitbucket.net.

lvermeulen avatar lvermeulen commented on June 27, 2024

I will push out a fix hopefully this weekend.

from bitbucket.net.

lvermeulen avatar lvermeulen commented on June 27, 2024

Fixed in release 2.1.6

from bitbucket.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.