Better warning message for Vis and VisList about lux HOT 6 CLOSED

Is an error message like this better? I just raised a syntax error since this behaves like a syntax error.

from lux.

Yeah, the SyntaxError seems appropriate here. I wonder if we could just map this into a VisList internally and still return something, but place a warning.

from lux.

I've been trying it out and my approach is to construct a VisList if the intent list length is greater than 1 and display that inside of Vis's repr_html - but, it seems to be a bit buggy cause we are trying to have two files import each other. I think we can do it if we turn VisList into something importable (i.e just doing import VisList or something like that) -> I dont know if having two files import each other is good practice though. Alternatively, we can merge Vis and VisList together so that we can construct a VisList inside the Vis and just display the VisList and throw the error after.

from lux.

You're right, it's probably not a good idea to have the two packages import each other. I recall this is one of the reasons why I separated them out in the first place. Let's opt for just showing the error message then, but making it a bit interpretable, something along the lines of:

The intent corresponds to more than one visualizations, please replace the Vis constructor with VisList to generate a list of visualizations. For more information, see: https://lux-api.readthedocs.io/en/latest/source/guide/vis.html#working-with-collections-of-visualization-with-vislist

from lux.

Resolved in #135

from lux.

The multi-vis error is not being thrown in this case, leading to other downstream errors that is harder for the user to parse.

df = pd.read_csv('https://github.com/lux-org/lux-datasets/blob/master/data/olympic.csv?raw=true')
df["Year"] = pd.to_datetime(df["Year"], format='%Y') # change pandas dtype for the column "Year" to datatype

from lux.vis.Vis import Vis
intent = ["Season=Winter|Summer","AthleteRegion"]
vis = Vis(intent,df)
vis

The check inside check_not_vislist_intent does not check for "|" or list notation.
We should extend the check to cover all scenarios where a VisList could be generated as well in the tests.

from lux.