Git Product home page Git Product logo

Comments (7)

eejdoowad avatar eejdoowad commented on August 11, 2024 2

Sorry Firefoxers. I must have botched last night's release somehow. My only excuse is... "it worked on my machine."

This should be a quick fix on my end, soon as I get access to ny dev machine.

Instituting a better review/testing process is another one for the Todos.

from saka-key.

patrickchin avatar patrickchin commented on August 11, 2024

I am using Nightly 57.0a1 (2017-08-29) (64-bit) and Saka Key 1.20.0rc. Saka Key does not work unless I change any setting/keybinding, it will then work for the rest of the session. This happened with older versions of Saka Key and Firefox too.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

Hi @patrickchin, the latest release 1.20.0 modified Saka Key such that for every release after 1.20.0, Saka Key should continue working in all open tabs without requiring any interaction from the user. It's good to know that v1.20.0 isn't fundamentally broken. @figdanivi, have you tried changing a settin?. Any setting. Changing a setting on the options page will trigger Saka Key clients on all open tabs to reset.

My next release will focus on making specifying and propogating options more stable. It'll hopefully resolve all the recent issues that have been posted about Saka Key breaking.

from saka-key.

 avatar commented on August 11, 2024

@eejdoowad That does not work.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

@figdanivi, can you try hitting the "Reset All Options button?".

from saka-key.

 avatar commented on August 11, 2024

That fixes it. Even after restoring my options, Saka Key continues to be responsive.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

Version 1.21.2 should hopefully resolve this issue. it's on the firefox dev channel now, and should be on the chrome webstore within a few days (it's been automatically rejected for the second time for not being single purpose).

I think #24, #27, and #29 are all related to the fact that I broke the logic for how keybindings are generated when I rewrote the options page for release 1.16.

See commit 37add11 for the details. The fix was pretty simple.

If your current version is already broken, reset your options using the "Reset All Options button" on the options page. If the problem persists after this reset, please add a comment to #24.

from saka-key.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.