Git Product home page Git Product logo

Comments (21)

eejdoowad avatar eejdoowad commented on August 11, 2024 4

@IGI-111 thanks! I had no idea beta channels existed. Firefox users, the beta channel now hosts version 1.18.0. Enjoy!

from saka-key.

IGI-111 avatar IGI-111 commented on August 11, 2024 1

Have you considered using the beta extension channel for intermediate releases? It doesn't have the approval constrainst and it would still allow for people to get the latest version from the marketplace to test.

from saka-key.

gliptak avatar gliptak commented on August 11, 2024 1

The beta channel direct link for current version is https://addons.mozilla.org/firefox/downloads/latest-beta/saka-key/addon-795406-latest.xpi?src=dp-btn-devchannel

Consider closing this issue.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

Thanks for the feedback. The next release will be published on Firefox (and fix a few Firefox specific bugs).

I'll also start posting Firefox releases together with chrome releases.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

Hi @magnus-staberg. I've just released version 1.11 and published it on chrome and firefox. The turn around time for firefox addons approval is usually long (multiple days to weeks).

Until then, try building Saka Key from version 1.11's commit (85e4290) by following the instructions in the readme (npm install && npm run build:prod:firefox).

from saka-key.

StabbarN avatar StabbarN commented on August 11, 2024

Great, thanks :)

I tried building and installing but can't figure out how to install it on Firefox. Firefox wanted a add-on file format but I found none in dist folder.

In firefox I open about:addons and then "Install add-on From File". Is this not the way to install it?
screen shot 2017-06-27 at 11 51 25

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

Currently, the easiest way is to navigate to about:debugging, click Load Temporary Add-on, select any file within the generated dist directory, and hit open.

Extensions loaded this way will automatically be removed when you close the browser.

npm run build:firefox generates a build that produces debug logs.
npm run build:prod:firefox excludes debug logs and is run through a minifier/optimizer, so it's noticably faster.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

Firefox isn't my daily driver, so if you experience any difficulties please let me know.

Firefox bugs I know about:

  • Scrolling the options GUI in the popup is broken... so you're better off opening the options GUI in a new tab.
  • Only opening links the standard way works. You can't, for example, open links in a background tab.

from saka-key.

StabbarN avatar StabbarN commented on August 11, 2024

I installed the locally built version, commit 85e4290, but cannot open the settings. the window clicking on the icon is empty and clicking options on info.html resolves to an empty page.

screen shot 2017-06-27 at 20 20 32

screen shot 2017-06-27 at 20 24 32

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

From my experience, that happens when you generate a chrome build by running npm run build instead of npm run build:firefox. Even after you load in the extension, make sure not to run npm run build because firefox uses whatever files exist in the dist directory.

Now that I think about it, I'll remove the commands npm run:buildand npm run:build:prod so you have to explicitly mention the target browser. This will help avoid confusion.

from saka-key.

StabbarN avatar StabbarN commented on August 11, 2024

I did npm run build:prod:firefox but retried with npm run build:firefox and that seems to be working better.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

That's strange. I'll look into it.

from saka-key.

StabbarN avatar StabbarN commented on August 11, 2024

I've activated Prevent Pages From Stealing Focus. On google it works for the first tapped key but the following keys will be insterted into the search input.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

It doesn't seem to work for me at all on google searches. It works fine on google.com

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

I think the 'Prevent Pages From Stealing Focus' issue, and many others relating to DOM event handling, have been resolved in version 1.14 (the latest commit).

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

I haven't been able to replicate your issue with loading production builds. I tried a fresh Ubuntu virtual machine with Firefox Developer Edition. Saka Key requires a recent version of Firefox. I advise using Firefox Developer addition.

from saka-key.

StabbarN avatar StabbarN commented on August 11, 2024

With google searches I meant searching on google.com
google.com is working a lot better in latest commit.

I checked out latest commit and successfully built npm run build:prod:firefox.

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

Great! I made some major architectural changes that should let the Firefox build work much reliably.

from saka-key.

gliptak avatar gliptak commented on August 11, 2024

https://addons.mozilla.org/en-US/firefox/addon/saka-key/ still shows version 1.3

If it is very time consuming keep Firefox up-to-date, could you consider offering "release" files (directly in the project)?

Thanks

from saka-key.

eejdoowad avatar eejdoowad commented on August 11, 2024

I apologize for the extended wait for Firefox updates. I submitted an update over a month ago and it's still sitting at 5 of 159 in the approval queue.

Hosting release files is an extra step in the development process that will slow it down (unless I spend time automating it). I figure my users are either: 1) developers who will have no problem following the build instructions in the readme, or 2) general users who won't get further than the firefox marketplace.

It's something l should do eventually, but there are so many other features and fixes I want to implement. Meanwhile, I take care to ensure the master branch always contains a working build. So git pull origin master && npm run build:prod:firefox should always get you the latest release.

from saka-key.

gliptak avatar gliptak commented on August 11, 2024

@eejdoowad No need to apologize for somebody else's slow review queue.

from saka-key.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.