Git Product home page Git Product logo

Comments (3)

glennjacobs avatar glennjacobs commented on June 1, 2024

I suggest we need to decide upon what the behaviour should be, and potentially show this in the hub along the lines of how Shopify do it. And then introduce tests to cover overlapping discounts to check they behave correctly.

from lunar.

ryanmitchell avatar ryanmitchell commented on June 1, 2024

To me the options are either:

  1. If an item is in a discount is excluded from future ones, ordered by the priority given through the Hub. If the line quantity is > 1 then consideration needs to be given that each might be in different discounts.

  2. Compound the discounts - so discounts needs to work from the discountedSubtotal not line subTotal

from lunar.

glennjacobs avatar glennjacobs commented on June 1, 2024

Thanks @ryanmitchell. @alecritson is going to work on this later this week, so we can look to finally get 0.2 released next week.

from lunar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.