Git Product home page Git Product logo

Comments (5)

glennjacobs avatar glennjacobs commented on June 6, 2024

It's a tricky one as then does the item also get automatically removed when you no longer qualify for the discount?

Happy to consider a PR. But think it would need to go into 0.3 now, as we really need to finish up on 0.2.

from lunar.

ryanmitchell avatar ryanmitchell commented on June 6, 2024

Yeah it would be automatically removed when no longer eligible. And yep it gets complicated :)

I’ll have a go at it over the next couple of weeks - happy for it to wait to 0.3

from lunar.

glennjacobs avatar glennjacobs commented on June 6, 2024

What if the user already had the item in their cart?

from lunar.

ryanmitchell avatar ryanmitchell commented on June 6, 2024

So I would suggest we use the meta on the cart line to indicate it was 'added_by' another cart line id(s) ... then if that/those cart lines are removed then it would remove the free discount.

The other option would be to flag it as added by a discount, then on cart item add/edit/remove we validate any line items added by discount to ensure they are still valid and if not remove them.

from lunar.

glennjacobs avatar glennjacobs commented on June 6, 2024

Sounds reasonable.

from lunar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.