Comments (5)
It's a tricky one as then does the item also get automatically removed when you no longer qualify for the discount?
Happy to consider a PR. But think it would need to go into 0.3 now, as we really need to finish up on 0.2.
from lunar.
Yeah it would be automatically removed when no longer eligible. And yep it gets complicated :)
I’ll have a go at it over the next couple of weeks - happy for it to wait to 0.3
from lunar.
What if the user already had the item in their cart?
from lunar.
So I would suggest we use the meta on the cart line to indicate it was 'added_by' another cart line id(s) ... then if that/those cart lines are removed then it would remove the free discount.
The other option would be to flag it as added by a discount, then on cart item add/edit/remove we validate any line items added by discount to ensure they are still valid and if not remove them.
from lunar.
Sounds reasonable.
from lunar.
Related Issues (20)
- Error when saving a product with a `Lunar\FrieldTypes\TranslatedText` attribute HOT 10
- Error when attaching `discount` to a `customerGroup` in the Admin Hub HOT 2
- Input values aren't being trimmed or validated when saved on resource
- test
- Not Required field "Name" in ACL page on create group action
- Lunarphp 1.x is not working with Model::shouldBeStrict(); because of dynamic attributes HOT 2
- Lunar 1.0: SQL Migration error when running migrations for the first time. HOT 2
- Attribute validation rules HOT 2
- Url::scopeDefault() types `QueryBuilder` instead of `EloquentBuilder` HOT 2
- No label for Collection when using a second locale.
- Undefined array key "email" when creating staff member
- Laravel 11 : Dependency Conflict: Unable to Install lunarphp/lunar 1.0.0-alpha.1 Due to laravel/framework Version Conflict HOT 3
- Lunar 1.0 Admin Panel: Decimal places bug when creating Discount, in Minimum Cart Amount & Amount (Fixed Value) HOT 1
- Orders list page - js errors HOT 2
- Migrations for causer_type field in activity_log table HOT 1
- Missing translations HOT 1
- Changing panel url not changes routes for custom resources HOT 9
- Removing currency throws error
- TaxBreakdown/Currency error at order line delete HOT 3
- Small doc bug - wrong location for invoice pdf
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lunar.