Avoid recommending curl bash piping about drupal9ci HOT 4 CLOSED

@deviantintegral is my security master, and he does the same thing at https://github.com/deviantintegral/drupal_tests.

We could turn this into a Robo collection, which would on one hand give us a lot of control over errors and on the other better feedback to users. Thoughts?

from drupal9ci.

I think the security side is covered as long as we're downloading over https. At that point, piping to the shell is not really different than downloading and running ./install.sh.

I'd never seen the interrupted pipe scenario before. That's a good one! Thanks for cleaning that up. I've got to use that for https://github.com/deviantintegral/drupal_tests/blob/master/setup.sh

I'm curious about somehow making this a composer package. I guess it would work by defining a custom installation type? I think the scripts section in a composer.json is root-only, so I'm not sure how we'd add and modify files inside of the .circleci directory.

from drupal9ci.

@q0rban do you think that what you did at #3 is enough to mark this issue as done?

from drupal9ci.

Yep!

from drupal9ci.