Git Product home page Git Product logo

Comments (8)

knewter avatar knewter commented on July 17, 2024

@prikhi I'm interested in tackling this, perhaps by using http://coala.io - it seems kind of perfectly suited for this. Would that be ok or would the additional dependency be bothersome? If I don't hear back from you I'll likely make a PR anyway... :D

from builtwithelm.

prikhi avatar prikhi commented on July 17, 2024

Haven't used coala before but seems OK to me 👍 ✨

from builtwithelm.

knewter avatar knewter commented on July 17, 2024

I might have to write a custom bear to check the image size but it's easy. Do you do CI anywhere yet? Could run this on travis, should be easy

from builtwithelm.

prikhi avatar prikhi commented on July 17, 2024

There's no CI for this repo atm, Travis is my usual go to.

from builtwithelm.

knewter avatar knewter commented on July 17, 2024

I've added a test for duplicate project names in projects.json - there were three, and I renamed them to specify the author after the project name

from builtwithelm.

knewter avatar knewter commented on July 17, 2024

getting the image size is way harder than it should be because coala is rejecting raw files even though there's explicitly a setting to allow this. Do you know of a good image linter?

from builtwithelm.

prikhi avatar prikhi commented on July 17, 2024

Dunno what is available on travis, but you could use identify from imagemagick:
identify -format "%wx%h" data/images/ABC-editor.jpg or just the file command w/ greps:

$ file ABC-editor.jpg | grep -oE "[^density] ([[:digit:]]+x[[:digit:]]+)" | grep -oE "\S+$"
1000x800

from builtwithelm.

joelclermont avatar joelclermont commented on July 17, 2024

@knewter Thanks for tackling this project! This is a very welcome addition.

from builtwithelm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.