Git Product home page Git Product logo

Comments (4)

lukeed avatar lukeed commented on June 21, 2024

Sorry, I do not care the slightest about eslint. If you know exactly what it's complaining about I can look at fixing it, but I'm not going to investigate otherwise. Eslint is replaced by tsc directly -- at least for errors like this.

from worktop.

dhrubabasu avatar dhrubabasu commented on June 21, 2024

It's complaining about this: https://github.com/lukeed/worktop/blob/master/src/ws.d.ts#L47

Eslint reads connect with type any:

Screen Shot 2021-07-07 at 5 07 10 AM

from worktop.

lukeed avatar lukeed commented on June 21, 2024

On your end, can you try this for the types file:

declare const connect: Handler;
export { connect };

from worktop.

dhrubabasu avatar dhrubabasu commented on June 21, 2024

Oh, that file doesn't have import type { Handler } from 'worktop'; at the top. Adding that fixes the issue on my end. I did have to modify the handler to this:

export const handler: Handler = async (request, response) => {
  const error = await connect(request, response);
  if (error) return error;
}

Screen Shot 2021-07-07 at 12 32 59 PM

Not a huge deal but could be a good idea to modify the connect type declaration to only require the request parameter as it does nothing with the response.

from worktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.