Comments (7)
With the changes in the next release, the above example can be consolidated into this:
import { Router } from 'worktop';
import * as Cache from 'worktop/cache';
const API = new Router;
// ...
// reusable function
const main = Cache.reply(API.run);
addEventListener('fetch', event => {
let request = event.request;
if (request.method !== 'POST') {
return main(event);
}
let clone = request.clone();
let key = toBodyHash(clone); // string
// use new `key` for cache lookup
return main(event, key);
});
from worktop.
There will be a req.cachekey
(name tbd) that allows you to customize the Cache's keyname to be used.
Until then, all the Cache methods already support custom keys w/ their final request?: string|Request
parameter. A string is treated as a GET request.
So you may want to do something like:
import { Router } from 'worktop';
import * as Cache from 'worktop/cache';
const API = new Router;
// ...
addEventListener('fetch', event => {
let request = event.request;
if (request.method !== 'POST') {
return Cache.reply(API.run)(event);
}
let clone = request.clone();
let key = toBodyHash(clone); // string
// basically the same as Cache.reply, but w/ custom request
event.respondWith(
Cache.lookup(event, key).then(prev => {
return prev || handler(event).then(res => {
return save(event, res, key);
});
})
);
});
Looking at this,
Cache.reply
should probably take an optionalrequest?
parameter.
from worktop.
I suppose it can be today
I'll merge in #54 and cut a new minor version later today
from worktop.
@dhrubabasu released 0.7.0 btw~!
from worktop.
With the latest changes in worktop@next
, this snippet (#53 (comment)) changes a little bit.
Now Cache.reply
returns a Module.Worker
definition (object), and there's no method that does the lookup
-> save
sequence for you, but it's pretty straightforward & it's more configurable now too:
import { Router } from 'worktop';
import * as Cache from 'worktop/cache';
const API = new Router;
// ...
async function reply(req, ctx, custom) {
let res = await Cache.lookup(custom || req);
if (res) return res;
res = await API.run(req, ctx);
return Cache.save(custom || req, res);
}
export default {
fetch(req, env, ctx) {
ctx.bindings = env;
if (req.method === 'POST') {
let hash = toBodyHash(clone); // string
return reply(req, ctx, hash);
}
return reply(req, ctx);
}
}
from worktop.
I've tried my hand at implementing this in worktop/cache
but running into some issues hashing the request body since I consume it in a handler.
from worktop.
@lukeed When the next release will be on npm?
from worktop.
Related Issues (20)
- Using Worktop in a Pages website HOT 3
- Use Sveltekit and worktop together? HOT 2
- How to set multiple cookies? HOT 2
- Worktop Middlewares Example HOT 4
- Durable Objects example HOT 2
- The example of timing requests might be misleading HOT 1
- Using official Cloudflare types HOT 4
- Can I use Worktop with Fastly Compute@Edge? HOT 1
- Is it going to be official by cloudflare?
- Cache API and KV: Concerns/Questions/Usage HOT 1
- How to access `.env` with Wrangler 2 HOT 2
- Provide a "test" module HOT 4
- Serving HTML files HOT 6
- How to use with cron / scheduled event ? HOT 2
- Is `worktop@next` safe to use in production? HOT 2
- Add generic typing for Router.add handler
- The uploaded script has no registered event handlers. [API code: 10068] HOT 1
- Add sub-routers HOT 2
- Node 16+ ESM TypeScript error HOT 1
- `isCacheable` allowed cache by default if the `cache-control` header is empty may leading to a security flaw in ssg content HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from worktop.