Match camelCase as well as PascalCase by first word letters when autocompleting about cshell HOT 9 CLOSED

Do I understand that what you are asking for is autocompletion to be case sensitive?

from cshell.

No, I don't think that's what I'm asking for. Let me clarify by giving a concrete example in CShell.

Enter the following in a CShell script and execute it:

public class SomeType {
    public static string multiWordMember;

    public static string MultiWordMember {get; set;}
}

We now have a type with two static members, one in camel case and one in pascal case.

Now in the REPL enter SomeType.mwm and look at the suggested autocompletions. I would expect the autocompletions to include both multiWordMember and MultiWordMember because in both cases mwm matches the first letter of each word in the member, but in fact only MultiWordMember is matched. I believe both members should be matched.

from cshell.

I’d argue for not naming things w/ only differing case. Ultra-confusing.

Said another way: if it hurts when you bang your head against the wall, don’t do that.

Now, if _multiWordMember and MultiWordMember weren’t matched, I’d be on board w/ the change…

From: Lawrence Johnston [mailto:[email protected]]
Sent: Tuesday, May 20, 2014 11:17 AM
To: lukebuehler/CShell
Subject: Re: [CShell] Match camelCase as well as PascalCase by first word letters when autocompleting (#26)

No, I don't think that's what I'm asking for. Let me clarify by giving a concrete example in CShell.

Enter the following in a CShell script and execute it:

public class SomeType {
public static string multiWordMember;

public static string MultiWordMember {get; set;}

}

We now have a type with two static members, one in camel case and one in pascal case.

Now in the REPL enter SomeType.mwm and look at the suggested autocompletions. I would expect the autocompletions to include both multiWordMember and MultiWordMember because in both cases mwm matches the first letter of each word in the member, but in fact only MultiWordMember is matched. I believe both members should be matched.

—
Reply to this email directly or view it on GitHub #26 (comment) . https://github.com/notifications/beacon/1967433__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNjIyMTc5OSwiZGF0YSI6eyJpZCI6MzI2MDY5NjB9fQ==--448568ef03a64e40d6d2915a6f27d14b405564e4.gif

from cshell.

Hmm, I see. Just looked how ReSharper would handle your example. It indeed knows how to match the different cases differently. The ReSharper "CamelHumps" matching is, of course, quite sophisticated. The completion algo is actually part of AvalonEdit, so we would need to improve it there.

For now, I'm quite happy with the completion algo, while I agree it could be better. We need to first work on fixing other completion problems like #4.

from cshell.

@bc3tech The members are named the same with different case in my example only to make the difference in behavior for pascal case vs camel case obvious. You oculd just as easily rename them to multiWordMemberField and MultiWordMemberProperty and still attempt to complete using mwm and have the same issue.

If it helps you could restate my request as follows:

I have a variable named someVariableName (I hope we can agree that it's reasonable to name a variable using camel case). I'm trying to autocomplete it, so I enter svn, which matches the first letter of each word in the variable name. It doesn't match. I would like it to match.

The fact that svn would match SomeVariableName in the current implementation is supporting evidence for why this seems like a reasonable request.

@lukebuehler Thanks for your input, that makes sense. Should this issue be filed over at Avalon Edit as well? Since it's part of Avalon Edit it's probably not in your hands, but if I were to look at addressing it over there would you consider it to be a change for the better?

from cshell.

@lawrencejohnston, yes I would post this issue there as well. Since it would have to be changed in AvalonEdit.

from cshell.

Does these mean we're happy to close?

from cshell.

@lawrencejohnston will close as wontfix since this is really work that needs to be done on the AvalonEdit project. I recommend opening this issue there, please let me know when you have done that so I can chime in on the conversation.

from cshell.

Opened as icsharpcode/AvalonEdit#1 and submitted pull request.

from cshell.