Git Product home page Git Product logo

Comments (9)

lfarah avatar lfarah commented on August 15, 2024 2

Ok, Step 1 is working! Now I'm gonna clean the code and go to step 2

from pine.

lukakerr avatar lukakerr commented on August 15, 2024

Great idea! As of right now, I think this is a bit out of scope since I'm still adding basic/fundamental features to Twig. I'll leave this issue open though and come back to it later after some more of the core features have been implemented

from pine.

lfarah avatar lfarah commented on August 15, 2024

I just got exporting to Gist working with a private token.
It definitely gets trickier when there's syncing, but at the moment I think it would be cool to add an Export to Gist feature.
Do you think an exporting feature would be cool? If so, I can definitely work on this feature. If not, I understand that there is more stuff that needs to be prioritized.

from pine.

lukakerr avatar lukakerr commented on August 15, 2024

If your keen to implement exporting to Gist then definitely go ahead! That would be awesome. Then in the future syncing could be added for sure

from pine.

lfarah avatar lfarah commented on August 15, 2024

This is where I'm at right now. My next steps are:

  1. Figure it out how we could use an actual Github login instead of just asking for a token
  2. Save this info in a safer place (Currently in UserDefaults)
  3. Have an exporting screen where the user can choose a file name, description and if it's public or private.

What are your thoughts?
twiggithub

from pine.

lukakerr avatar lukakerr commented on August 15, 2024

That looks great, nice work.

For point 1, is it possible to show a GitHub web login window (opened from preferences window) where the user can sign in and we can grab the token from that? I think this is how most apps authorize with GitHub.

For 2, we should most probably do this using the Keychain.

For 3, I agree, some sort of pop up window when the user clicks export would be nice to have. I plan to add something like this for all export options sometime in the future anyway where the user can choose all sorts of options for their export.

from pine.

lukakerr avatar lukakerr commented on August 15, 2024

Also, I noticed in the gif that the sidebar icon section at the bottom has a white background, is this how it always is for you? It shouldn’t be like that, I will fix that up

from pine.

lfarah avatar lfarah commented on August 15, 2024

Thanks!

from pine.

lukakerr avatar lukakerr commented on August 15, 2024

@lfarah How are you going on this? Even if you're not done, do you want to perhaps open a pull request with whats done so far?

from pine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.