Git Product home page Git Product logo

Comments (14)

AbhiBajpaishek avatar AbhiBajpaishek commented on July 20, 2024

If we use a pre-commit hook to format with every commit, will that work? As prettier will already we installed as a dev dependency.

from ecohabit.

lugenx avatar lugenx commented on July 20, 2024

i am not familiar with pre-commit hooks, if that solves the problem it's great actually. could you take care of that?

from ecohabit.

AbhiBajpaishek avatar AbhiBajpaishek commented on July 20, 2024

I've also never implemented this myself but I want to pick this up. Could you please edit the Issue title and assign this ticket to me?

from ecohabit.

lugenx avatar lugenx commented on July 20, 2024

edited and assigned, thank you.

from ecohabit.

AbhiBajpaishek avatar AbhiBajpaishek commented on July 20, 2024

Facing hurdles on this as we have mono repo kind of setup and preCommit is struggling as there are mutiple package.json and .git file is not in same folder as in package.json.

I'm still trying will keep updated.

from ecohabit.

lugenx avatar lugenx commented on July 20, 2024

thank you for the update.

from ecohabit.

lugenx avatar lugenx commented on July 20, 2024

@AbhiBajpaishek, are you still working on this? I know this is a tricky issue. I also couldn't figure it out. I will remove an assignment from this to see if it can catch the attention of someone with a solution. Please still let me know if you find out.

from ecohabit.

AyanDas348 avatar AyanDas348 commented on July 20, 2024

@lugenx Hi I have some idea on how to use pre-commit hooks to resolve this issue. Can I work on it?

from ecohabit.

lugenx avatar lugenx commented on July 20, 2024

hi @AyanDas348 , sure, please go ahead. I have assigned this issue to you 👍

from ecohabit.

itegika avatar itegika commented on July 20, 2024

hi @lugenx , if this issue is open, assign it to me, please. Thanks

from ecohabit.

lugenx avatar lugenx commented on July 20, 2024

sure, i assigned this to you @itegika, please make sure that you read all the comments above before starting to work. let me know if you have any questions.

from ecohabit.

itegika avatar itegika commented on July 20, 2024

Sure, thank you)

from ecohabit.

itegika avatar itegika commented on July 20, 2024

Hi, @lugenx , sent PR regarding this issue https://github.com/lugenx/ecohabit/pull/233
Thanks

from ecohabit.

AyanDas348 avatar AyanDas348 commented on July 20, 2024

Hi, @lugenx found a solution using husky. Is that an option available?

from ecohabit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.