Git Product home page Git Product logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 20, 2024
Hi,

I downloaded the plugin and had a look at the code. I think I found a bug in 
how the proxy parameters were managed.
Here is my proposed patch:

diff --git a/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java 
b/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java
index 6793085..f6c3148 100644
--- a/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java
+++ b/src/main/java/com/google/appengine/appcfg/AbstractAppCfgMojo.java
@@ -236,6 +236,8 @@

     arguments.add(action);
     arguments.add(appDir);
+    
+    getLog().debug("passing arguments: " + arguments.toString());

     try {
       AppCfg.main(arguments.toArray(new String[arguments.size()]));
@@ -280,13 +282,12 @@
     }

     if (proxyHost != null && !proxyHost.isEmpty()) {
-      arguments.add("--proxy");
+      arguments.add("-p");
       arguments.add(proxyHost);
     }

     if (proxyHttps != null && !proxyHttps.isEmpty()) {
-      arguments.add("--proxy_https");
-      arguments.add(proxyHttps);
+      arguments.add("--proxy_https="+proxyHttps);
     }

     if (noCookies) {

Original comment by [email protected] on 6 Dec 2013 at 7:48

from appengine-maven-plugin.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 20, 2024
I need this fix as well. The workaround that I used is to pass the proxy 
settings on the maven command line:

mvn -DproxySet=true -DproxyHost=proxy.example.com -DproxyPort=8080 ...

But I definitely want the fix and not my band-aid. Ideally it would be nice if 
this could use the maven proxy settings in my settings.xml. 

Original comment by [email protected] on 19 Dec 2013 at 9:39

from appengine-maven-plugin.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 20, 2024
This bug applies to all parameters which expect an equal sign between the 
parameter name and its value. So in the current version this bug should affect 
parameters proxy, proxy_https, jar_splitting_excludes, num_days, severity e 
num_runs.

I also need this fix. 

Original comment by [email protected] on 14 May 2014 at 5:35

from appengine-maven-plugin.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 20, 2024
Fix will be in 1.9.7
For now, you can 
$ git clone https://code.google.com/p/appengine-maven-plugin/
$ cd appengine-maven-plugin
$ mvn install

and use the version 1.9.7-SNAPSHOT in the plugin version as a workaround until 
1.9.7 is pushed

Original comment by [email protected] on 14 Jun 2014 at 4:58

  • Changed state: Accepted

from appengine-maven-plugin.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 20, 2024

Original comment by [email protected] on 14 Jun 2014 at 4:58

  • Changed state: Fixed

from appengine-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.