Git Product home page Git Product logo

Comments (3)

ffelten avatar ffelten commented on June 13, 2024

Hi @omidsbhn,

Thank you for the bug report :-)!

Indeed, it seems there is something off there. One (or more) bug might have slipped in, we didn't thoroughly tested this algorithm yet tbh.

I tried to use squeeze and compare to the current implementation, can't say it changes much (green is fixed, purple is current implem):
image

I would appreciate it we keep digging on this and discuss the implementation if you want :-)

from morl-baselines.

omidsbhn avatar omidsbhn commented on June 13, 2024

Hi @ffelten
Thank you for checking the issue so quickly :-)
For me the graphs are almost the same, but I think for more complex environments, it could be an issue.
Btw, I would be happy to discuss the implementation and keep digging on this. Specifically, based on this implementation I'm trying to regenerate the ablation study suggested by the paper.

from morl-baselines.

ffelten avatar ffelten commented on June 13, 2024

You can join the discord for direct communication https://discord.com/invite/jpYmEFNT

from morl-baselines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.