Where should be placed business logic? about opencqrs HOT 14 CLOSED

You can set it for the whole app and still be able to override it on a command basis by simply override the property SaveCommand

from opencqrs.

Great!

from opencqrs.

Commit here: 473cb1b

from opencqrs.

I put the business logic in the handler itself and in the aggregate. Everything related to event sourcing happens under the hood. Command handlers are the equivalent of buissness services in a layered architecture.

from opencqrs.

Yes, but if I need works with some confidential data (some encryption data, etc).
So, if I do it in commands it's data writes to DomainCommands table in not encrypted format.

Also, If I need to do some manipulation with data, and return result from command, not store it.

from opencqrs.

These are two options I could add, not store the commands and return a result.

from opencqrs.

It would be great. It would solve the problem (Do private logic, and don't store anything) and also allows to return result. It's very needed.

I like this repo, and your work.
And I think, I can help with some tasks.
I like this very simple and good solution https://github.com/jbogard/MediatR .
MediatR - allows to return result.
And we can build something like this.
Thank you.

from opencqrs.

Hi @Ilchuk-Mihail, sorry for the delay, tough time between work and uni :-)
I'm trying to find the best way to add a configuration option for saving commands at the global level and at the command level.
Not sure about returning results for the commands. Ideally commands should not return anything, but maybe it might be useful to return the event(s) generated.

from opencqrs.

Doing some experiments in the dev branch: https://github.com/OpenCQRS/OpenCQRS/tree/Dev

from opencqrs.

I have added global configuration options that can be set during registration (default value is true):

services
  .AddOpenCqrs(typeof(CreateProduct), typeof(GetProduct))
  .AddOptions(x => { x.SaveCommands = false; })
  .AddSqlServerProvider(Configuration)
  .AddServiceBusProvider(Configuration);

and the default setting can be overridden for every command using the new property SaveCommand of the IDomainCommand interface:

public interface IDomainCommand : ICommand
{
    Guid Id { get; set; }
    Guid AggregateRootId { get; set; }
    string UserId { get; set; }
    string Source { get; set; }
    DateTime TimeStamp { get; set; }
    int? ExpectedVersion { get; set; }
    bool? SaveCommand { get; set; }
}

from opencqrs.

Maybe he meant to do this in a by-command basis? and not for the whole app?

[SaveCommand(false)]
public class CreateProduct : DomainCommand

[UnpersistedCommand]
public class CreateProduct : DomainCommand

public class CreateProduct : UnpersistedDomainCommand

Or similar approaches.

TIL: https://en.wiktionary.org/wiki/unpersist

from opencqrs.

I'm wondering if it might be better to still save the command but not the data associated to it.

from opencqrs.

@lucabriguglia
Thanks for help.

I'm wondering if it might be better to still save the command but not the data associated to it.

In my opinion, it is a better way. That way we can track all events and commands which happened in the app. We will not have any gaps.

from opencqrs.

@lucabriguglia
Thanks for help.

I'm wondering if it might be better to still save the command but not the data associated to it.

In my opinion, it is a better way. That way we can track all events and commands which happened in the app. We will not have any gaps.

I agree, I would change the SaveCommand property to SaveCommandData.

from opencqrs.