[Idea] Simplify dispatcher - Make callee responsible it's actions about opencqrs HOT 6 CLOSED

Got something working!

To test the demo:

• Clone my repo change to branch simplifyDispatcher.
• Breakpoint on CommandSender Line 41.
• Run in Debug mode OpenCqrs.Examples.Web.EF.SqlServer example project.

Important part:
https://github.com/andreujuanc/OpenCQRS/blob/simplifyDispatcher/src/OpenCqrs/Commands/CommandSender.cs#L41

There, or somewhere else is where the library should decide on its on what to execute.

So it can have the data that before was passed trough generics, now it's set in the actual command, like so:

 public class CreateProduct : DomainCommand<Product>
 {
        public string Title { get; set; }
 }

With handler like this:

  public class CreateProductHandler : ICommandHandlerWithDomainEventsAsyncWOOT<CreateProduct>
  {
      public async Task<IEnumerable<IDomainEvent>> HandleAsync(CreateProduct command)
      {
          await Task.CompletedTask;
          var product = new Product(command.AggregateRootId, command.Title);
          return product.Events;
      }
  }

This way the command changes from this:

await dispatcher.SendAndPublishAsync<CreateProduct, Product>(new CreateProduct());
To this:
await dispatcher.SendAsyncWOOT(new CreateProduct());

REMARKS:

• I have not tested performance or any issue related to this implementation.
• Probably all the type generation can be cached efficiently.
• This introduces breaking changes, might be a good thing for v6?

from opencqrs.

I like the idea of making commands responsible of the aggregate root definition and I would like to do the same for queries/results.
I'm not so sure about the implementation in the command sender tough, I'll give it a try in the next few days.

from opencqrs.

Based on your suggestion I'm adding a new global option and a property to the ICommand interface in order to publish or not the event. You can follow the progress on the dev branch: https://github.com/OpenCQRS/OpenCQRS/tree/Dev

from opencqrs.

Great! will take a look a it!

from opencqrs.

Thanks @andreujuanc

from opencqrs.

Breaking changes here: https://github.com/OpenCQRS/OpenCQRS/releases

from opencqrs.