Make it possible to prevent the UnsupportedOperationException at class loading time about zstd-jni HOT 7 CLOSED

You can make it a little bit shorter as the load method will do nothing if it is already loaded:

    public static boolean zstdAvailable() {
        try {
            Native.load();
            return Native.isLoaded();
        }
        catch (Throwable t) {
            return false;
        }
    }

from zstd-jni.

Yes, looks reasonable... I will look how to make it possible.

from zstd-jni.

Thanks!

Perhaps for inspiration (in case you weren't aware) checkout the jpountz/lz4-java bindings that automatically switch between native and java implementation.

from zstd-jni.

Yes, thanks. The loader is actually based on the same code from lz4-java.

from zstd-jni.

BTW, can you try something like this:

InputStream is = null;
try {
  com.github.luben.zstd.util.Native.load();
  is = ZstdInputStream(....);
} catch (Throwable e) {
  is = GzipInputStream(....);
}

I think it should work as the static initialization is not executed if the class is never used. BTW, it's the same mechanism used by the LZ4

from zstd-jni.

You are completely right, I was confused on when exactly static blocks are executed.
I now mangled the jar to exclude the binaries for my platform and indeed it works.

    public static boolean zstdAvailable() {
        try {
            if (Native.isLoaded()) {
                return true;
            }
            Native.load();
            return Native.isLoaded();
        }
        catch (Throwable t) {
            return false;
        }
    }

this is the method I constructed, and indeed doesn't fail, as long as it is called before any construction of the zstd classes.

Sorry for the issue, I think you could close it, or perhaps add a boolean method to the Native class that signals it can't be loaded?

from zstd-jni.

ah yes, due to the:

        if (loaded) {
            return;
        }

from zstd-jni.