Comments (2)
MathematicalDessert
commented on July 17, 2024
1
I think that direction makes sense. But perhaps WAS (warnings-as-errors) should also be enabled by default for all builds, but make it easy for developers to disable via flag as you mentioned.
Following this direction assumes that developers using different compilers will eventually resolve warnings as they come (and hopefully this is the case). It's not ideal but I think it's important to have them as errors to enforce good code standards.
from luau.
vegorov-rbx
commented on July 17, 2024
I believe we should disable warnings as errors by default.
We will always be behind the new warnings that are developed in compiler updates.
from luau.
Related Issues (20)
- For loop variable types not inferred from generic iterator with new type solver
- `and` `or` expression causes type pack error with new type solver's strict mode
- `table.freeze` returns type `{+ +}` with new solver's strict mode HOT 1
- failed assert in script file crashes repl HOT 1
- Stack overflow in parser HOT 3
- `buffer` library `TypeError` when buffer is function parameter with new solver's non-strict mode
- Cyclic union with upvalue not reducing `TypeError` with new solver's strict mode
- TypeError: Type pack '...any' could not be converted into 'a...' in new solver's strict mode
- Comment in lgc.h wrongly describes the GC invariant? HOT 1
- Test doesn't do what it says it does HOT 2
- TypeError when indexing table with union/intersection type of identical types
- Variables pack not inferred correctly for `__iter` metamethod
- Add type checking to `Luau.Web.js`
- Incorrect type widening with multiple arguments to generic `T` with new solver HOT 4
- String keys are not checked against table indexer
- Cannot cast into union with literal with new solver's strict mode
- Type refinement rememberance for statically labeled variables assigned to Engine API.
- `luacode.h` uses code not valid in C HOT 2
- Unassigned Generic Types break types unification in new type solver
- "Free Types and {- -}" causes the "autocomplete type and owning area MainModule" to be appended in the old type solver, and don't work in the new type solver HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luau.