Cannot compile Luau.Repl.CLI on Android device from Termux about luau HOT 9 CLOSED

I've reopened this issue because I believe we still need the patch for the code to compile.

from luau.

Does something like this make it work?

diff --git a/CLI/FileUtils.cpp b/CLI/FileUtils.cpp
index 0702b74..fff5e42 100644
--- a/CLI/FileUtils.cpp
+++ b/CLI/FileUtils.cpp
@@ -142,6 +142,7 @@ static bool traverseDirectoryRec(const std::string& path, const std::function<vo
             joinPaths(buf, path.c_str(), data.d_name);

             int type = data.d_type;
+            int mode = -1;

             // we need to stat DT_UNKNOWN to be able to tell the type
             if (type == DT_UNKNOWN)
@@ -153,18 +154,18 @@ static bool traverseDirectoryRec(const std::string& path, const std::function<vo
                 lstat(buf.c_str(), &st);
 #endif

-                type = IFTODT(st.st_mode);
+                mode = st.st_mode;
             }

-            if (type == DT_DIR)
+            if (type == DT_DIR || mode == S_IFDIR)
             {
                 traverseDirectoryRec(buf, callback);
             }
-            else if (type == DT_REG)
+            else if (type == DT_REG || mode == S_IFREG)
             {
                 callback(buf);
             }
-            else if (type == DT_LNK)
+            else if (type == DT_LNK || mode == S_IFLNK)
             {
                 // Skip symbolic links to avoid handling cycles
             }

from luau.

kid why are you trying to compile on android LOL

from luau.

Does something like this make it work?

diff --git a/CLI/FileUtils.cpp b/CLI/FileUtils.cpp
index 0702b74..fff5e42 100644
--- a/CLI/FileUtils.cpp
+++ b/CLI/FileUtils.cpp
@@ -142,6 +142,7 @@ static bool traverseDirectoryRec(const std::string& path, const std::function<vo
             joinPaths(buf, path.c_str(), data.d_name);

             int type = data.d_type;
+            int mode = -1;

             // we need to stat DT_UNKNOWN to be able to tell the type
             if (type == DT_UNKNOWN)
@@ -153,18 +154,18 @@ static bool traverseDirectoryRec(const std::string& path, const std::function<vo
                 lstat(buf.c_str(), &st);
 #endif

-                type = IFTODT(st.st_mode);
+                mode = st.st_mode;
             }

-            if (type == DT_DIR)
+            if (type == DT_DIR || mode == S_IFDIR)
             {
                 traverseDirectoryRec(buf, callback);
             }
-            else if (type == DT_REG)
+            else if (type == DT_REG || mode == S_IFREG)
             {
                 callback(buf);
             }
-            else if (type == DT_LNK)
+            else if (type == DT_LNK || mode == S_IFLNK)
             {
                 // Skip symbolic links to avoid handling cycles
             }

This patch works for me

from luau.

Great, thanks for confirming.

from luau.

Managed to get it working after realising what I was doing was incorrect (talking about the second comment)

from luau.

Managed to get it working after realising what I was doing was incorrect (talking about the second comment)

You got it working without the patch?

from luau.

I've reopened this issue because I believe we still need the patch for the code to compile.

Yeah, the patch is still needed for compiling on Android.

from luau.

Ok - if someone with the device can test that with the patch, you can still run luau-analyze on a folder of source code (as a commandline argument) and can then make a PR that would be appreciated.

from luau.