Corrections proposed to index.php and pages/* files about self-service-password HOT 9 CLOSED

Thanks for the tips.

What is the advantage of using array() instead of [] ?

from self-service-password.

array() allows support for php < 5.4 and it's the traditional way. I don't
think there is other differences.

@coudot what is the minimum php version required for ssp ?
I assumed it's 5.4 based on the travis file.

Is it possible that op is using php <= 5.2 and also edited the recaptcha
lib to make it work on its platform ? (no short notation, no namespace)

On Fri, Nov 11, 2016, 13:53 Clément OUDOT [email protected] wrote:

Thanks for the tips.

What is the advantage of using array() instead of [] ?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArKrZ33ZWpI_PbCDDI6u5vm0P4Q-_avks5q9GVXgaJpZM4KvpEI
.

from self-service-password.

I did not test SSP for PHP versions under 5.4, but this version should be enough for most of people. Do you need to use SSP with older PHP version?

from self-service-password.

I use php 5.2.10 and I am not sure if the correction for recaptcha files I proposed is correct! It just worked! When it was "\Recaptcha\Recaptcha..." I was getting a syntax error. If a php >= 5.4 is needed then the developper should mention it on a "Requirements" section.

from self-service-password.

I will test your change to see if it works also for php >= 5.4

from self-service-password.

It will not work. The recaptcha will be unresolved with this change (i
think i can safely assume op is not using recaptcha). the recaptcha needs
5.4 because it uses namespaces.

On Fri, Nov 11, 2016, 14:59 Clément OUDOT [email protected] wrote:

I will test your change to see if it works also for php >= 5.4

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArKrfeUMmrOqHMCxu8uak6AlSLyd05hks5q9HSqgaJpZM4KvpEI
.

from self-service-password.

Seems Recaptcha patch does not work:

[Fri Nov 11 15:18:29.258129 2016] [:error] [pid 3340] [client 127.0.0.1:52290] PHP Fatal error:  Uncaught Error: Class 'ReCaptcha' not found in /home/clement/dev/self-service-password/pages/change.php:68\nStack trace:\n#0 /home/clement/dev/self-service-password/index.php(206): include()\n#1 {main}\n  thrown in /home/clement/dev/self-service-password/pages/change.php on line 68, referer: http://ssp.example.com/index.php

So I will not apply it.

from self-service-password.

Sorry for being too fast to propose the recaptcha tip and too slow to
answer your posts! :-)
Indeed all depended on me having an old php version (5.2). I switched to
5.4 and everything worked out of the box! Again, sorry for your time!

Nikos Asimos

2016-11-11 16:20 GMT+02:00 Clément OUDOT [email protected]:

Seems Recaptcha patch does not work:

[Fri Nov 11 15:18:29.258129 2016] [:error] [pid 3340] [client 127.0.0.1:52290] PHP Fatal error: Uncaught Error: Class 'ReCaptcha' not found in /home/clement/dev/self-service-password/pages/change.php:68\nStack trace:\n#0 /home/clement/dev/self-service-password/index.php(206): include()\n#1 {main}\n thrown in /home/clement/dev/self-service-password/pages/change.php on line 68, referer: http://ssp.example.com/index.php

So I will not apply it.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWUMMrxBFoW-oYzyeeHQlLROm70xAqvBks5q9HnBgaJpZM4KvpEI
.

from self-service-password.

Thanks for the feedback.

from self-service-password.