Git Product home page Git Product logo

Comments (7)

jdreesen avatar jdreesen commented on September 24, 2024

If you develop in a PHP 7 env but your production env is PHP 5 you should set Composer's platform config to the PHP version of your prod system and Composer will only install versions of the libs compatible with it ;)

from functional-php.

ahungry avatar ahungry commented on September 24, 2024

That's a great suggestion (thank you!) but the fact isn't just that the package changed the dependency - version 1.2 makes use of PHP7 only features, which means it is not backwards compatible with version 1.0 (environments that can run 1.0 will never be upgraded to 1.2 - luckily thanks to composer, but the versioning itself should handle this properly, unless there is just no desire to follow the versioning convention).

If I pin version ~1.0 I should expect to receive features/bugfixes up to but excluding version 2.0.0 which I would expect to be incompatible.

I guess I don't understand the versioning scheme being used (why lock into 1.x like this?)

from functional-php.

jdreesen avatar jdreesen commented on September 24, 2024

Well, I'm not the author/maintainer of this package but I tend to agree regarding a major PHP version change.

However I just looked in the composer.json and it says "php": ">=5.6.0" for version 1.2 / master. In addition the travis builds seems to run fine with PHP 5.6 too and thus I'm not sure why you think that PHP 7 is required for the latest version?

Regarding the rise of the PHP minor version from 5.3 in v1.0 to 5.6 in v1.2 I think this is a valid change, even if PHP 5.6 supports more features and thus isn't fully backwards compatible, because PHP 5.3 is EOL'ed for quite some time now (even PHP 5.5 security support ends in less than a month) and should not be used anymore.

from functional-php.

ahungry avatar ahungry commented on September 24, 2024

Ah that was my mistake (my own use case happened to be PHP7 on one machine PHP 5.5.9 on the Ubuntu 14.04 LTS machine - I completely forgot about PHP 5.6).

Still, I think altering the minimum viable PHP version should warrant more than a minor version bump on this end.

from functional-php.

lstrojny avatar lstrojny commented on September 24, 2024

I have no plans so far to abandon 5.6 support. Closing for now.

from functional-php.

ahungry avatar ahungry commented on September 24, 2024

The issue was that you abandoned sub-5.6 support without doing a major version bump

from functional-php.

jdreesen avatar jdreesen commented on September 24, 2024

The real issue is using unsupported PHP versions ;)

from functional-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.