Git Product home page Git Product logo

Comments (5)

lsirivong avatar lsirivong commented on July 19, 2024

Hey @sashafklein! Sorry to hear the trouble you're having here. If you could spin up a sample project it would help me take a look at this more quickly and understand what the issues are here.

from gatsby-plugin-modal-routing.

mhigley avatar mhigley commented on July 19, 2024

@sashafklein Have you had any success with getting this package to work with TransitionLink? I am trying to do the same.
@lsirivong Are there any updates to this issue? Examples or clarifications?

from gatsby-plugin-modal-routing.

sashafklein avatar sashafklein commented on July 19, 2024

@lsirivong -- So sorry! I guess my notifications were off. I ended up moving in another direction, and didn't make the modals navigable, so didn't figure this out.

from gatsby-plugin-modal-routing.

zuzy-dev avatar zuzy-dev commented on July 19, 2024

hey @lsirivong, @mhigley -- hope you’re doing well in this crazy times.

i'm also running into this.

i prepared this codesandbox

the link-component can be found in '../components/PostListing' (line 29)
when removing "gatsby-plugin-transition-link", from gatsby-config.js and restarting the sandbox the modal works as exspected.

maybe you have a hint to solve this interference. thanks!

EDIT: Here is a more simple example codesandbox, based on gatsby-starter.

from gatsby-plugin-modal-routing.

lsirivong avatar lsirivong commented on July 19, 2024

@lucasdon thank you!

Frankly, I'm not spending much time working on gatsby sites so I'm not able to dig into this. What I can say is the this plugin uses link state to signal that the modal should be rendered. I noticed that gatsby-plugin-transition-link calls navigate manually it some places, so maybe the state is getting lost somehow.

Happy to help shepherd PRs or advise anyone who's looking into the issue if it would be helpful, but I'm probably not going to be able to dig into this deeply anytime soon.

from gatsby-plugin-modal-routing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.