Git Product home page Git Product logo

Comments (5)

lgarithm avatar lgarithm commented on September 24, 2024

instead of adding retry time for Control msg, I added a Wait API (#295), and called it before sending the Control msg.

I think this has two benefits:

1). we don't want to set retry time for every Control msg, some Control msg can fail by design.
2). Wait is a generic API that has a clear semantics, it can be used in conjunction with the Control msg or other APIs to achieve desired effect.

from kungfu.

zrss avatar zrss commented on September 24, 2024

@lgarithm , thanks for the reply, totally agree;

from kungfu.

zrss avatar zrss commented on September 24, 2024

hope this problem can be solved soon ~ as there is a high risk to trigger it when we scale up the job in kubernetes cluster, due to we can't keep the strict time sequence about making the kung-fu runner running and then update the config.json

from kungfu.

lgarithm avatar lgarithm commented on September 24, 2024

@zrss can you try the new master.
Default wait timeout is 5m, and can be set via
export KUNGFU_CONFIG_WAIT_RUNNER_TIMEOUT=10m

from kungfu.

zrss avatar zrss commented on September 24, 2024

@lgarithm , thanks, now it works well

from kungfu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.