Git Product home page Git Product logo

Comments (5)

amroamroamro avatar amroamroamro commented on September 6, 2024

thank you for the fix.

I pulled the latest 1.3.4 version, and tried again the same example above. While the code block is properly rendered using a pre/code tags, however there is an extra 4 spaces at the beginning of the code section (inside <pre>):

<p>This is a list:</p>
<ul>
<li>
<p>first item, with some code:</p>
<pre><code>    int x = 10;</code></pre>
</li>
<li><p>second item</p></li>
</ul>
<p>Thank you</p>

The double indentation is part of the markdown syntax to mark code blocks within lists, so no leading spaces should show up in the output HTML (only those beyond the 8 spaces must).

thanks again for looking into this.

from markdownpapers.

lruiz avatar lruiz commented on September 6, 2024

I will look into this, before releasing it.

Thank you for reporting.

from markdownpapers.

lruiz avatar lruiz commented on September 6, 2024

Done!!!, fixed he extra 4 spaces.

from markdownpapers.

amroamroamro avatar amroamroamro commented on September 6, 2024

great, much appreciated! The code section is properly indented now.

This is not high priority, but I was wondering how the code behaves when there are more than 8 spaces. So I took the liberty of comparing the output with other Markdown parsers accessible online:

Using 9 spaces, it seems that the majority of parsers maintain the extra space in the pre/code block (really anything beyond the required eight), although there are a few instances that truncate them like this project.

Now I'm not sure which one is part of the standard, I just thought I should mention it here...

Anyway thank you for fixing the main bug.

from markdownpapers.

amroamroamro avatar amroamroamro commented on September 6, 2024

👍 awesome, thank you for the quick fix

from markdownpapers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.