Git Product home page Git Product logo

Comments (15)

lrsjng avatar lrsjng commented on May 17, 2024

That is already working: ctrl and drag an area will add/remove entries from the current selection. ctrl click will not work, you have to drag at least 1 px.

from h5ai.

majksner avatar majksner commented on May 17, 2024

It seems it doesn't work on Mac :( On Windows looks fine. Mac replacement for Control is Command button. How I can modify files to get it working on Mac?

from h5ai.

lrsjng avatar lrsjng commented on May 17, 2024

Ah, okay, that's not good

That is the line that checks for the ctrl key (uses the jQuery event object):
http://github.com/lrsjng/h5ai/blob/master/src/_h5ai/js/inc/ext/select.js#L115

from h5ai.

majksner avatar majksner commented on May 17, 2024

It will be very hard for me to change this since I'm using packed and minified JS from the zip file :(

from h5ai.

lrsjng avatar lrsjng commented on May 17, 2024

use a text editor of your choice and search and replace the hopefully single occurrence of "event.ctrlKey" with "event.metaKey". maybe this works for mac.

from h5ai.

majksner avatar majksner commented on May 17, 2024

I need both Windows and Mac covered.

from h5ai.

lrsjng avatar lrsjng commented on May 17, 2024

then replace "!event.ctrlKey" with "!event.ctrlKey && !event.metaKey". can't test it myself since i don't have access to a mac.

from h5ai.

lrsjng avatar lrsjng commented on May 17, 2024

does it work?

from h5ai.

majksner avatar majksner commented on May 17, 2024

Didn't try yet. I'll let you know.

Nikola Majksner
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, May 17, 2012 at 17:31, Lars Jung wrote:

does it work?


Reply to this email directly or view it on GitHub:
#65 (comment)

from h5ai.

chimpy avatar chimpy commented on May 17, 2024

Thought I'd chime in to say that this works perfectly fine for me on my Mac.

from h5ai.

lrsjng avatar lrsjng commented on May 17, 2024

That are good news..!

Just let me know: are you using 0.20 or 0.21-pre? does it work with the apple command key or the control key? is there a system context menu popping up for you?

Thanks

from h5ai.

chimpy avatar chimpy commented on May 17, 2024

I'm using the 0.21-pre you sent me the other day on lighttpd-1.4.28 with Safari 5.1.2 :) I used held the command key and dragged. You can't hold it and click items to select them, but it's pretty intuitive to just drag and select one item. De-selecting works fine too. You never get a contextual menu with the command key.
The control key + click results in the contextual menu, no way to drag with that.

Proof: http://cl.ly/I8cw

from h5ai.

lrsjng avatar lrsjng commented on May 17, 2024

So you are lewis, I guess? :) Thanks for the feedback! So I close this issue.

from h5ai.

lrsjng avatar lrsjng commented on May 17, 2024

Fixed in 0.21

from h5ai.

chimpy avatar chimpy commented on May 17, 2024

That's me!

from h5ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.