string:tokens/2 and string:strip/3 will be deprecated about rebar3_appup_plugin HOT 9 CLOSED

Thanks! Would you mind turning it into a PR?

from rebar3_appup_plugin.

closing via #40

from rebar3_appup_plugin.

@benbro should be good now, can you give it a try please?

from rebar3_appup_plugin.

Tested with:

{plugins, [
    {rebar3_appup_plugin, {git, "https://github.com/lrascao/rebar3_appup_plugin.git", {branch, "develop"}}}
]}.

Getting another error:

===> Compiling _build/default/plugins/rebar3_appup_plugin/src/rebar3_appup_generate.erl failed
_build/default/plugins/rebar3_appup_plugin/src/rebar3_appup_generate.erl:808: string:tokens/2: deprecated; use string:lexemes/2 instead
_build/default/plugins/rebar3_appup_plugin/src/rebar3_appup_generate.erl:897: string:tokens/2: deprecated; use string:lexemes/2 instead
_build/default/plugins/rebar3_appup_plugin/src/rebar3_appup_generate.erl:899: string:tokens/2: deprecated; use string:lexemes/2 instead

from rebar3_appup_plugin.

Did you mean to replace "right" with "left"?
Old:

string:strip(binary_to_list(DataBin), right, $\n),

New:

string_compat:strip(binary_to_list(DataBin), left, $\n),

from rebar3_appup_plugin.

nice catch, it is wrong, should be right

from rebar3_appup_plugin.

on what OTP version are you getting those deprecated errors? is it master?

from rebar3_appup_plugin.

Yes, OTP master.

from rebar3_appup_plugin.

The new PR fix string:token/2 in rebar3_appup_generate and strip direction.

from rebar3_appup_plugin.