Git Product home page Git Product logo

Comments (3)

lpil avatar lpil commented on May 18, 2024

What do you think the expected output should be?

How would you describe the rule? Bare in mind that there are module attributes in Elixir core such as @doc, @spec, @tag and spec that are expected to sit on the line above the def.

Other similar module attributes are used in libraries and tools on hex.pm (such as Credo) too.

Perhaps we could insert a space between a module attribute followed by a comment.

from exfmt.

cschneid avatar cschneid commented on May 18, 2024

I was thinking that it's hard to do this in a general way.

Types that I see:

  • known elixir attributes that "attach" to a function (@doc, @spec)
  • known elixir attributes that don't attach (@type, @opaque, @before_compile and such)
  • application-specific module attributes that "attach" to a function tightly (from your code)
  • module-wide "constants" (like what I have above, or more complex ones like this from your code)

I imagine you can have specific rules for those first 2. But I'm not sure a generalized rule for the ones that people come up with themselves.

from exfmt.

lpil avatar lpil commented on May 18, 2024

New thought- we could use the line numbers in AST node metadata to detect when a user has deliberately left blank spaces. Blank spaces could then be preserved.

from exfmt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.