Comments (4)
This is a sound idea. I've added a version of it to the version in svn, and it
will be included in the next release.
The one change I made is to the name. The "X-Forwarded-For" header gives a
comma-separated list of the servers the request was forwarded to. The first
one will be the original client, the rest will be proxies it passed through
before reaching the proxy whose IP is given in the IP environment variable.
Most commonly it will be used to get the first IP address, which is the
original client IP, not a proxy. So calling the variable PROXY seems confusing.
I called it FORWARDS instead, plural as a reminder that this is, in general,
going to be a list of IPs, not just a single IP.
Anyway, thanks for the contribution.
Original comment by [email protected]
on 11 Dec 2013 at 7:14
from mod-auth-external.
Issue 13 has been merged into this issue.
Original comment by [email protected]
on 11 Dec 2013 at 7:16
from mod-auth-external.
Original comment by [email protected]
on 11 Dec 2013 at 7:25
- Changed state: Fixed
from mod-auth-external.
Actually, on second thought, I think that making the IP environment variable
always return the client IP is better. No authenticator will ever really want
to know the whole chain of forwards.
So this change is out again.
Original comment by [email protected]
on 11 Dec 2013 at 7:42
from mod-auth-external.
Related Issues (20)
- checkpassword method appears to be broken in 3.2.x version HOT 5
- Internal Server Error when using SSL Virtual Host HOT 2
- Group Authentication not passing 'GROUP' env or argv variables HOT 4
- Modification to allow an loadbalancer between browser and server HOT 1
- 1 minute wait before auth HOT 9
- Mod-auth-external Needs a New Maintainer HOT 1
- no php environment when using pipe HOT 5
- passing data as base64 to prevent injection HOT 2
- PAM ENV variables for auth script
- Environment to include REQUEST_METHOD - feature request HOT 1
- Excellent documentation! HOT 1
- Is mod_authnz_external thread-safe?
- Failure stops other authenticators HOT 1
- Makefile has install for default target should be build HOT 1
- Patch for /trunk/mod_authnz_external/mysql/mysql-auth.pl HOT 1
- Cant compile source (mod-auth-external) HOT 3
- Use on Windows with Apache 2.2 HOT 1
- [Patch] conn_rec->remote_ip compilation failure with Apache 2.4.1 HOT 3
- authnz_external_module and pwauth on CentOS 6.2 failure HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mod-auth-external.