Comments (2)
Thanks for the detailed proposal. My understanding of this is that there are 2 main topics being discussed here, both of which are a good idea.
- Fix the bug to allow the use of a
flip
and/orflip
operation when also using parameter-lessrotate()
for images containing EXIF Orientations 2, 4, 5 or 7. - Add syntactic sugar for the parameter-less
rotate()
, either a constructor property as you suggest or perhapsautoOrient()
(e.g. #711). This would involve improving the docs to make it clear that both auto-orientation androtate(angle)
can be used in the same pipeline and will deprecate use of the parameter-lessrotate()
.
(Providing a runtime environment variable to control this feels like pain for me rather than benefit for thee, so no interest in that, sorry.)
from sharp.
Sounds like a winning compromise! I completely understand that taking on new features is very tricky since now you have to support them. I think adding the syntactic sugar for .rotate()
will actually solve the problem in most cases for downstream wrappers, because now they would need to support an additional command with a different name, thus preventing them from missing the nuance inherent to .rotate
's various invocations.
And I could be wrong (because I got in and out of several patches of weeds) but I think that sharp(img).rotate().rotate(90)
does not currently work the way one might think about it. The 90 degree rotation is not applied in addition to the orientation, but rather instead of it. Double check me, but I am pretty sure that is the case. I'll adjust my branch to change the API to match what you'd prefer. At the very least, I'll rebase against some tests that fail on the cases we'd be trying to adjust for.
from sharp.
Related Issues (20)
- Error sharp with HEIC files - bad seek to 293616\nheif: Unsupported feature: Unsupported codec (4.3000) HOT 3
- Webpack node-loader support + cross-compilation HOT 4
- Handling HEIC files in an Electron application and distributing HOT 2
- Unexpected rotation behavior for different size outputs after upgrading Sharp HOT 1
- Feature Request: Please support running in a browser (without node.js) HOT 2
- electon,win32,ia32,install ok,but pack and run ,it's error,"The specified procedure could not be found." HOT 3
- how to cache sharp binaries? HOT 1
- Sharp HEIC export is 4.4x bigger than equivalent macOS Finder export HOT 5
- Vercel production issue: .jpeg({ quality: XX }) not working at all - works in local env HOT 9
- PNG Conversion Failure HOT 2
- Resizing results in low quality/blurry image HOT 6
- Resize images while keeping the ICC profile and color space HOT 4
- Installation fails when trying to install as a dependency with global libvips on macOS HOT 4
- sharp 在获取某些webp图片元数据时导致文件句柄未被正确释放 HOT 2
- Sharp is present in node_modules but still got error in server logs. Error: 'sharp' is required to be installed in standalone mode. HOT 6
- Bug: type metadata.chromaSubsampling as union with undefined HOT 1
- Channel excluded from image manipulations, if the channel was `join`ed at later time HOT 4
- In network contrained environement we shoud have a diferent url for github like an artifactory proxy HOT 1
- Divide Blend HOT 1
- Help converting raw input with color-profile to srgb HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sharp.