Git Product home page Git Product logo

Comments (3)

CommanderStorm avatar CommanderStorm commented on June 16, 2024

Sort of in conflict (or at least interaction is unclear/difficult) with #508

I think adding a disable_notification toggle from the telegram api and #508 are an alternative.

Maybe a good alternative merging the approaches would be to have this as a mult-selection box (notify for => UP/DOWN/other).
What do you think about these alternatives?

Tip

Notification provider specific changes are really hard to keep up with. If you want to get there faster, you can consider contributing a change to the notification provider12

Footnotes

  1. https://github.com/louislam/uptime-kuma/blob/master/server/notification-providers/telegram.js ↩

  2. https://github.com/louislam/uptime-kuma/blob/master/src/components/notifications/Telegram.vue ↩

from uptime-kuma.

adriangalilea avatar adriangalilea commented on June 16, 2024

Sort of in conflict (or at least interaction is unclear/difficult) with #508

Completely missed this one, I searched for notification not alert.

I think adding a disable_notification toggle from the telegram api and #508 are an alternative.

Maybe a good alternative merging the approaches would be to have this as a mult-selection box (notify for => UP/DOWN/other). What do you think about these alternatives?

This would be awesome yes.

Tip

Notification provider specific changes are really hard to keep up with. If you want to get there faster, you can consider contributing a change to the notification provider12

I could totally help with telegram implementation once #508 is done, I've worked a lot with the telegram API and currently working full stack and typescript.

But as of now #508 blocks this.

from uptime-kuma.

CommanderStorm avatar CommanderStorm commented on June 16, 2024

Just noticed that disable_notification is already an option we implement.
=> don't think anything is needed in this department

What #508 needs should be pretty simple to implement.

The shared part of the notification dialog is here:

https://github.com/louislam/uptime-kuma/blob/dbbc79a05a2036176c8b011401c915c0db3384ca/src/components/NotificationDialog.vue

Notifications in the backend are send here

uptime-kuma/server/notification.js

Lines 164 to 170 in dbbc79a

static async send(notification, msg, monitorJSON = null, heartbeatJSON = null) {
if (this.providerList[notification.type]) {
return this.providerList[notification.type].send(notification, msg, monitorJSON, heartbeatJSON);
} else {
throw new Error("Notification type is not supported");
}
}

from uptime-kuma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.