Git Product home page Git Product logo

Comments (2)

LouisBarranqueiro avatar LouisBarranqueiro commented on June 16, 2024 2

Hey @tphan18 @human-a , I released a fix in v1.1.4. I started working to officially support React 16. For that, I have to upgrade all the test setup to run all the tests suite with react 16, 15, 14.

from reapop.

 avatar commented on June 16, 2024

I am also getting the following errors on react 16

Warning: Expected `onClick` listener to be a function, instead got a value of `string` type.
    in div (created by Notification)
    in Notification (created by Connect(Notification))
    in Connect(Notification) (created by NotificationsContainer)
    in CSSTransitionGroupChild (created by TransitionGroup)
    in span (created by TransitionGroup)
    in TransitionGroup (created by CSSTransitionGroup)
    in CSSTransitionGroup (created by NotificationsContainer)
    in div (created by NotificationsContainer)
    in NotificationsContainer (created by NotificationsSystem)
    in div (created by NotificationsSystem)
    in NotificationsSystem (created by Connect(NotificationsSystem))
    in Connect(NotificationsSystem) (at index.js:100)
    in div (created by FocusTrap)
    in FocusTrap (created by HotKeys)
    in HotKeys (at index.js:99)
    in Studio (created by Connect(Studio))
    in Connect(Studio) (created by RouterContext)
    in RouterContext (created by Router)
    in Router (at index.js:52)
    in Provider (at index.js:51)
Warning: Expected `onMouseEnter` listener to be a function, instead got a value of `string` type.
    in div (created by Notification)
    in Notification (created by Connect(Notification))
    in Connect(Notification) (created by NotificationsContainer)
    in CSSTransitionGroupChild (created by TransitionGroup)
    in span (created by TransitionGroup)
    in TransitionGroup (created by CSSTransitionGroup)
    in CSSTransitionGroup (created by NotificationsContainer)
    in div (created by NotificationsContainer)
    in NotificationsContainer (created by NotificationsSystem)
    in div (created by NotificationsSystem)
    in NotificationsSystem (created by Connect(NotificationsSystem))
    in Connect(NotificationsSystem) (at index.js:100)
    in div (created by FocusTrap)
    in FocusTrap (created by HotKeys)
    in HotKeys (at index.js:99)
    in Studio (created by Connect(Studio))
    in Connect(Studio) (created by RouterContext)
    in RouterContext (created by Router)
    in Router (at index.js:52)
    in Provider (at index.js:51)
Warning: Expected `onMouseLeave` listener to be a function, instead got a value of `string` type.
    in div (created by Notification)
    in Notification (created by Connect(Notification))
    in Connect(Notification) (created by NotificationsContainer)
    in CSSTransitionGroupChild (created by TransitionGroup)
    in span (created by TransitionGroup)
    in TransitionGroup (created by CSSTransitionGroup)
    in CSSTransitionGroup (created by NotificationsContainer)
    in div (created by NotificationsContainer)
    in NotificationsContainer (created by NotificationsSystem)
    in div (created by NotificationsSystem)
    in NotificationsSystem (created by Connect(NotificationsSystem))
    in Connect(NotificationsSystem) (at index.js:100)
    in div (created by FocusTrap)
    in FocusTrap (created by HotKeys)
    in HotKeys (at index.js:99)
    in Studio (created by Connect(Studio))
    in Connect(Studio) (created by RouterContext)
    in RouterContext (created by Router)
    in Router (at index.js:52)
    in Provider (at index.js:51)

PS.

Managed to fix it by changing line 233 to 236 inside Notification.js file to the following:

onClick: isDismissible && !closeButton ? this._remove : function(){},
onMouseEnter: timer ? this._pauseTimer : function(){},
onMouseLeave: timer ? this._resumeTimer : function(){}

from reapop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.