Bad Credentials in Git Enterprise integration - can't login about gistpad HOT 14 CLOSED

Yep you solved it :D Just merged your PR and I'll ship that in a few minutes 👍

from gistpad.

Thanks for reporting this! This error indicates that the token isn’t valid for accessing the Gists API. Couple of follow up questions:

1. Could you try appending “/gists” to the URL you’re trying to hit in Postman (or whichever HTTP you’re using) and see if that works?

2. Could you verify that the token you generated included the gist scope?

Thanks!

from gistpad.

Thanks for reporting this! This error indicates that the token isn’t valid for accessing the Gists API. Couple of follow up questions:

1. Could you try appending “/gists” to the URL you’re trying to hit in Postman (or whichever HTTP you’re using) and see if that works?
2. Could you verify that the token you generated included the gist scope?

Thanks!

1. Yeah https://git.myorg.com/api/v3/gists also works and returns the gists
2. Double checked that -- indeed it includes gists.

Anywhere to look at debug logs?

from gistpad.

Maybe I'll add the following.
The Open Gists command (CMD+P) actually works:

But the side menus don't

from gistpad.

@guyk-yahoo Interesting! The command palette and tree views work off the same data store, so it would seem like the authentication is working, but maybe you have an issue with the tree? Did you try both the Gists view on the Explorer tab, as well as the entirely separate GistPad tab? Do neither work for you?

from gistpad.

@guyk-yahoo Interesting! The command palette and tree views work off the same data store, so it would seem like the authentication is working, but maybe you have an issue with the tree? Did you try both the Gists view on the Explorer tab, as well as the entirely separate GistPad tab? Do neither work for you?

@lostintangent
Yep.
Both doesn't work

(Sorry about the two profiles - this is my personal profile, and I was writing from my work Github profile)

from gistpad.

@lostintangent
I think I have found the problem when I tried to debug the issue manually.

In node_modules/github-base/lib/utils.js - when I'm trying to debug the extension - I'm getting this (HardCoded):

When I switch https://api.github.com in that compiled file to my url - everything works well.

I'm not sure about how settings are passed there, but I feel it's a good lead

--- Update ---
I feel the problem is here:
https://github.com/vsls-contrib/gistpad/blob/master/src/store/auth.ts#L11

When creating the GitHub object, you don't pass the GitHub API URL, I'm not sure according to the documentation if you even can, but this seems to fail the authentication.
I'm not sure the github-base package is extensive enough to support custom GitHub apis.

I'm using in a different project of mine this: @octokit/rest (https://github.com/octokit/rest.js/) docs:(https://octokit.github.io/rest.js/) - which I think is far more extensive.

from gistpad.

@lostintangent ummmm I think I solved it.
Checkout the PR ^^

from gistpad.

Just shipped the update with this fix. Thanks so much for your help here!

from gistpad.

@lostintangent - Hey.
In the Explorer everything seems to be right.
In the dedicated Gist tab - it's still empty :(

from gistpad.

Are you using VS Code Insiders or Stable?

from gistpad.

Stable

from gistpad.

Do me a favor and open the GistPad and then reload VS Code (running the “Reload Window” command). After doing that, does the tab get populated with data?

I think there might be a bug in VS Code, where if a tree view is contributed to two different tabs, then only the first one that’s loaded is rendered properly.

from gistpad.

@lostintangent
Yeah - I did exactly this - only one of the two will work.
Known bug?

from gistpad.