Git Product home page Git Product logo

Comments (7)

Lornatang avatar Lornatang commented on June 2, 2024

This is a known issue and correct

from esrgan-pytorch.

JonathanPrexl avatar JonathanPrexl commented on June 2, 2024

Thanks for your fast answer!

Is there any known workaround or solution for that?

from esrgan-pytorch.

qiangwang57 avatar qiangwang57 commented on June 2, 2024

Thanks for your fast answer!

Is there any known workaround or solution for that?

Hello,

You can check here https://github.com/AlexiaJM/RelativisticGAN, which mentioned if you use BCELoss (which is used in ESRGAN), you need to add sigmoid as the last layer of the Discriminator (which is not included here). However, BCEWithLogitsLoss is recommended as it will do sigmoid implicitly.

from esrgan-pytorch.

Vonuo avatar Vonuo commented on June 2, 2024

Thanks for your fast answer!
Is there any known workaround or solution for that?

Hello,

You can check here https://github.com/AlexiaJM/RelativisticGAN, which mentioned if you use BCELoss (which is used in ESRGAN), you need to add sigmoid as the last layer of the Discriminator (which is not included here). However, BCEWithLogitsLoss is recommended as it will do sigmoid implicitly.

Hello,
"add sigmoid as the last layer of the Discriminator" can't solve the problem, because "hr_output" will still larger than "sr_output" sometime.

from esrgan-pytorch.

Vonuo avatar Vonuo commented on June 2, 2024

This is a known issue and correct

Hello,
Is this problem really corrected? i still get the same problem.

from esrgan-pytorch.

Lornatang avatar Lornatang commented on June 2, 2024

If you use BCEWithLogits, it will be more stable than SIgmoid+BCELoss,

from esrgan-pytorch.

Lornatang avatar Lornatang commented on June 2, 2024

This point is not mentioned in the original paper, but it is actually a key factor in the successful training of GAN

from esrgan-pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.