Use async/await about server HOT 10 CLOSED

Part of the works was done in #58

@chafilin can you show me links to the code, where you have problems in replacing Promise?

from server.

@chafilin don’t forget about tests. They are the main users of .then.

from server.

Part of the works was done in #58

@chafilin can you show me links to the code, where you have problems in replacing Promise?

This kind of Promises:

from server.

Yeap. Let’s keep Promise in those 2 examples.

I am waiting for PR to replace then in tests.

from server.

The current list of .then in project

➜ rg "\.then"
server-client.js
275:      .then(result => {

base-server.js
388:        .then(() => Promise.all(before))
389:        .then(keys => new Promise((resolve, reject) => {
405:    promise = promise.then(() => {
410:      promise.then(() => {
420:    return promise.then(() => {
424:    }).then(() => {
921:        }).then(access => {
960:            }).then(() => emitSubscribed())
964:        }).then(access => {

test/force-promise.test.js
4:  return forcePromise(() => Promise.resolve('result')).then(result => {
11:  return forcePromise(() => Promise.resolve().then(() => {
19:  return forcePromise(() => 'result').then(result => {

test/base-server.test.js
580:  app.destroy().then(() => {

test/stress/client.js
70:  delay(Math.random() * 10000).then(() => {

test/stress/backend.js
46:    let processing = delay(500).then(() => {
50:      processing = processing.then(() => {
52:      }).then(() => {
58:      }).then(() => {
62:      processing = processing.then(() => {
64:      }).then(() => {
68:    processing.then(() => {

Seems like we have only a few lines to close this issue.

from server.

a369b48
b99e4be
72f6894
6399e06
66d61c4

from server.

What is the reason for the forcePromise module? You can await promises and non-promises.

from server.

API was created before await.

Good idea to remove it. Do you want to send PR?

from server.

Hmm, I would, but one test fails and I don't know why.
The test reports about errors during channel authorization has this assertion:
expect(test.names).toEqual(['add', 'clean', 'error', 'add', 'clean'])
But test.names is ['add', 'error', 'add', 'clean', 'clean'] without the forcePromise.

from server.

1. I forgot to say you send PR to v0.6 branch instead of master
2. You can find reports content in test.reports. Comparing `test.reports before and after changes could help you with finding a difference. It is OK if the content is the same, but only the order was changed.
3. If it will become too complicated you can send failing PR, I will help with tests.

from server.