Comments (3)
Just figured, buildInitializerDefineProperty
could be changed to this:
const buildInitializerDefineProperty = template(`
function NAME(target, property, descriptor, context){
if (!descriptor || !descriptor.initializer) return;
context[property] = descriptor.initializer.call(context);
}
`);
That way a setter defined on the prototype has a chance to react to the initialization assignment, whereas using Object.defineProperty
will just skip the setter on the prototype :-/
from babel-plugin-transform-decorators-legacy.
If I take a closer look at babel-plugin-transform-class-properties, I can see it has an option spec
, which by default is false. If option spec
is false (default), an assignment is emitted. And only of if spec
is true, it will use Object.defineProperty
to initialize.
Therefore: The default should be what I proposed in my last comment. And if one would be fancy, either read somehow the spec
option from transform-class-properties
or provide an own spec
option to still emit Object.defineProperty
for initialization.
from babel-plugin-transform-decorators-legacy.
spec
exists because it is what the spec dictates, and it will default to true
in future versions of Babel. The goal of this plugin is to mimic the behavior of decorators as they were implemented in Babel 5. I'm not looking to add enhancements like this.
What you want should be doable in future versions of the decorators spec, but implementing that is beyond the scope of this plugin. Until then, maybe you can get what you want by defining it as @syncFromFoo
instead?
from babel-plugin-transform-decorators-legacy.
Related Issues (20)
- Error: Cannot read property of undefined. Static properties HOT 4
- @observable static has a Error
- Extract decorated functions as top level variables HOT 7
- Class property decorator hack. HOT 4
- What can be done to make decorators real in and move from stage-1 to stage-4? HOT 4
- [bug]Parameter Decorator does not work HOT 2
- About the parameter decorator support HOT 1
- Class property decorators gets applied before the class decorator itself HOT 4
- Issues with Electron HOT 19
- undefined is not a constructor (evaluating 'new u') HOT 2
- plugin not working HOT 4
- A issue in React-Native HOT 3
- Incorrect local name w/ native classes & babel-minify
- Maximum call stack size exceeded
- Clarify what babel's `legacy: true` is for exactly HOT 1
- Module build failed : Error:Cannot use the decorators and decorators-legacy plugin together
- Module parse failed: Unexpected character '@' (15:0)
- Audit vulnerabilities detected in the babelplugintransformdecoratorslegacy project on Tag: v1.3.5
- No lock file found in the babelplugintransformdecoratorslegacy project on Tag: v1.3.5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babel-plugin-transform-decorators-legacy.