Incorrect behavior in DailyRollingFileAppender::close() about log4cplus HOT 6 CLOSED

This roll on close behaviour is historical. I am not sure if it is necessary, though. DailyRollingFileAppender is a strange beast. I guess what we can do is to and a property that would allow you to turn this roll-over on close off.

from log4cplus.

Would you mind if I add RotateOnShutdown property to DailyRollingFileAppender and probably TimeBasedRollingFileAppender ? Actually I have implemented the change locally and it seems it solves the issue. Of course the name of the property is the subject to discuss

from log4cplus.

Not at all. Just keep the default as is the current historical behaviour.

from log4cplus.

Also, unless RotateOnShutdown already exists elsewhere (log4j, log4net, etc.) let's use a different name: RollOnClose.

from log4cplus.

I've created a pull request for this issue, as well as two other small pull request and a merge for your convenience.

from log4cplus.

closed as #123

from log4cplus.