MediaCloud Plugin overrides Illuminate collapse() function about poet HOT 10 CLOSED

hmm strange. is it throwing an error?

from poet.

No explicit error, but when MediaPress is disabled everything works awesome. When it's enabled I did a var_dump on the collection chained methods and collapse returns an empty array rather than the proper response of the post types.

The method from MediaPress is slightly different so that's where my assumption lies with their class.

So technically it's a soft failure. Also this is a brand new Sage 10 project and MediaPress is currently the only plugin other than ACF.

from poet.

Confirmed the issue. Will try to push a fix tonight.

from poet.

That's amazing! Looking forward to seeing how you resolved it and thanks a ton for providing a fix.

from poet.

Going to test tonight the newest version 4.2.5 as it looks like a lot updated from MediaPress. Will let you know if the issue still persists.

from poet.

Tested with 4.2.5. Still have the same issue unfortunately.

from poet.

yeah. annoyingly they are autoloading helpers.php from their old Illuminate\Support\Collection and it's registering the collect() helper before Sage's. I fixed it on https://github.com/Log1x/poet/pull/16/files but it's not stable yet.

its likely for inconsistencies like this to show up elsewhere down the road unless they were to fix registering their custom collect in the global namespace.

from poet.

Gotcha. Anything I can do to help?

from poet.

If you have time to burn, feel free to try that PR so far. I will have to swing back around to it tonight – I honestly can't remember where I left off. :(

from poet.

Sounds good, I'll fork it and see what I come up with in the next day or two.

from poet.