Comments (3)
It's an interesting idea but I'm not sure about it because it may be better to have one application definition that can be applied to x namespaces.
Can't you simply set the target namespace (destination) in Argo and that should achieve what you want? In the application definition rather than in the manifests: spec.destination.namespace
If we were to add the namespace in the output and you wanted an application deployed x times in x namespaces, that would not be possible anymore. Right now, it's easily possible by commiting one singe output of devspace to git and have multiple Argo applications with different namespaces.
from component-chart.
It's an interesting idea but I'm not sure about it because it may be better to have one application definition that can be applied to x namespaces.
Can't you simply set the target namespace (destination) in Argo and that should achieve what you want? In the application definition rather than in the manifests:
spec.destination.namespace
If we were to add the namespace in the output and you wanted an application deployed x times in x namespaces, that would not be possible anymore. Right now, it's easily possible by commiting one singe output of devspace to git and have multiple Argo applications with different namespaces.
Hi @LukasGentele , thanks for taking the time. I understand your point of view and your proposed solution, which unfortunately doesn't apply to me because I am not using exactly argocd but another similar product.
Can I then propose an alternate solution, which is using a specific value namespace
. then the chart could have something like:
{{- if .Values.namespace-}}
namespace: {{- .Values.namespace -}}
{{- end -}}
The value name can be anything you'd like of course. And I'd be happy to submit a PR.
from component-chart.
Great idea to work with values instead. Looking at devspace-sh/devspace#1782 , we may want to make this more flexible, e.g.
namespace:
name: xxx
annotations: ... # can be added later
labels: ... # can be added later
While name is the only thing we need at first, to add namespace to the service, deployment etc. (= your issue) making the namespace as an object may be more flexible for down the road if we want to add other things to the namespace definition itself (= referenced issue above).
Any thoughts regarding their solution for either one of these issues? Would that work for you?
Thanks for suggesting this @wollowizard! Would love to see a PR from you. Please note that you'd also need to add a PR to DevSpace itself to add the new values options of the component chart to the devspace.yaml
from component-chart.
Related Issues (20)
- volumeClaimsTemplate is generated for Deployments HOT 2
- ipFamily isn't a thing
- Wildcard domain causing parsing issues
- [feature request] support job template
- Allow NodePort to be specified for services to allow connection to services such as databases HOT 1
- feature: support podSecurityContext, serviceAccounts HOT 2
- [docs] `imagePullPolicy` is not documented
- Question: how to use given chart version HOT 1
- volumes only used in initContainers are omitted from manifests HOT 1
- Unsupported CertManager Annotations
- inconsistent app.kubernetes.io/name label
- usage of CSI drivers in volume.....
- Autoscaling doesn't work for deployments with volumes
- [docs] Document containers.*.envFrom
- Error when setting averageRelativeMemory in autoScaling.horizontal
- Is it foreseeable to have more general metrics in the HPA?
- [feature-request] Allow to add ConfigMaps inline HOT 1
- no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1" HOT 2
- No way to specify container ports
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from component-chart.