Git Product home page Git Product logo

Comments (4)

lmartinking avatar lmartinking commented on May 13, 2024

Hi @akaihola , thanks for the report!

I believe I've fixed it now on master. Care to give it a try?

from webscreensaver.

akaihola avatar akaihola commented on May 13, 2024

Well, I didn't actually try to enable WebGL, I just happened to notice this looking at the source code. It now looks correct to me.

Although unless you expect self.browser.get_settings() to fail in normal operation, you should probably move that before the try: block.

Also, using logging instead of print statements would enable you to easily print out the exception, too:

logging.exception('Could not enable WebGL')

from webscreensaver.

lmartinking avatar lmartinking commented on May 13, 2024

Hi @akaihola, I recall if a setting didn't exist, or could not be set, then an exception was thrown.

I'm not against using logging per se, but as a single script rather than a full on application, print is simpler.

from webscreensaver.

lmartinking avatar lmartinking commented on May 13, 2024

(Closing due to issue being 3 years old)

from webscreensaver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.