Lower FIRRTL module to RTL module about circt HOT 5 CLOSED

Yeah I'd love to see this. I'm not sure the best way to handle this. The existing lowering pass is parallel across FModuleOps, so it isn't supposed to touch the enclosing CircuitOp. I think it would make sense to keep this, but then add a subsequent pass over the CircuitOp that lowers the modules. This allows parallelism across the module level, and then a quick cleanup pass that lowers the modules themselves.

from circt.

@River707 does this seem sensible to you? Any precedent we should be aware of here?

from circt.

I was wondering the same thing for the FIRRTL-to-LLHD pass. It currently runs on CircuitOp, but running in parallel on FModuleOp and doing a cleanup pass as @lattner suggests is a great idea.

from circt.

I'm going to take a look at this

from circt.

Finally landed in fcf8f8b !

from circt.